Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 10/11] soc: ti: k3-ringacc: Use correct device for
 allocation in RING mode
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>, <nm@ti.com>,
        <t-kristo@ti.com>, <ssantosh@kernel.org>, <lokeshvutla@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20200928083429.17390-1-peter.ujfalusi@ti.com>
 <20200928083429.17390-11-peter.ujfalusi@ti.com>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <3bbe1568-3ceb-07df-4c40-bcc54c8935c0@ti.com>
Date:   Wed, 30 Sep 2020 16:58:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200928083429.17390-11-peter.ujfalusi@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 28/09/2020 11:34, Peter Ujfalusi wrote:
> In RING mode the ringacc does not access the ring memory. In this access
> mode the ringacc coherency does not have meaning.
> 
> If the ring is configured in RING mode, then the ringacc itself will not
> access to the ring memory. Only the requester (user) of the ring is going
> to read/write to the memory.
> Extend the ring configuration parameters with a device pointer to be used
> for DMA API when the ring is configured in RING mode.
> 
> Extending the ring configuration struct will allow per ring selection of
> device to be used for allocation, thus allowing per ring coherency.
> 
> To avoid regression, fall back to use the ringacc dev in case the alloc_dev
> is not provided.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>   drivers/soc/ti/k3-ringacc.c       | 14 +++++++++++---
>   include/linux/soc/ti/k3-ringacc.h |  5 +++++
>   2 files changed, 16 insertions(+), 3 deletions(-)
> 
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii