Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4625009pxk; Wed, 30 Sep 2020 07:45:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpNL218KyNlK3PWWNwLTkIG9rb/htX3ovAX6+rkBoeXSWOPHW5la6utnrJGMI+Vp4T0iOB X-Received: by 2002:a05:6402:1148:: with SMTP id g8mr3185052edw.271.1601477113098; Wed, 30 Sep 2020 07:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601477113; cv=none; d=google.com; s=arc-20160816; b=LFATY7Wmn62sQJ5R1lOtkqf44nwCBtxNTv1RO/RmlyBaFWs73xkA79tT8hcnmRWZUz 6f4U3Y/01nnkNzZDmTXpY5lsfPF89QaK2e1/d3LpPSDEA273XT8WBUJfppjw0j+ZsyMo fkc3F7JOh9pWoLquE+JJUQufHbkmHsptaYcm4wmKJAk3x2SP1OvFSfqhZblE9Tk3cciw wB3x/zJ/AHnjEAW0Zjg7d5hxm+nf1iBTE/sLq/Is7iDelRQu3wre3HMLsJ+2ptR+2og0 5PV/PjPHDQ9vuYy8OCV7IF3vntU/laKDzueC1sLUiaqfZatFN9SF0YA+G9Qid1wgHJN1 uPfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=6Lys2W6r4uZ+JX1Onj0nOj2DyGILV+GiicWVaaDTbhY=; b=I1yCkmwBfer9TsYoKTSJiJmQkfcpd85x6DNGOAXhogq4GAVjJdUi9mt44nb7ulzOs9 qhOz6OK+p9/Qx7pdwVX/KKzV3HGK3vK1XbKMLskNQX5OlagYHxujqX7OJA/ZmgOk8RPu sjB2fZNy+JkEg/o5XNoJWqHEYJubKh/+4RKaYMe9e1yIoCac6QI+9k6ST0C/Usd34K1p /FXPT7IHBS5ILTMzoRdNZ/MsRMLgnE03Os+NusYLGHsVfsJc9/HXKCMzRoVm+jORNy+7 izc1JereEkMXYMQMsRr1AG3fPcyOgOFztuLcEn2SQkv+6l3l2i+8G8Y2gHYFGJTHeTie IwZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JNkZLJZ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt15si1351564ejb.22.2020.09.30.07.44.50; Wed, 30 Sep 2020 07:45:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JNkZLJZ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730601AbgI3Olb (ORCPT + 99 others); Wed, 30 Sep 2020 10:41:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728149AbgI3Olb (ORCPT ); Wed, 30 Sep 2020 10:41:31 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30A08C061755; Wed, 30 Sep 2020 07:41:31 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id x69so2464693lff.3; Wed, 30 Sep 2020 07:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6Lys2W6r4uZ+JX1Onj0nOj2DyGILV+GiicWVaaDTbhY=; b=JNkZLJZ5MRllsBCJdpRE1u37X/c/q+oLZP1F3LbzZqGrxmckGpJY1wzFXFntooiqf2 Dq4ZuCHwjgbTQc2wZMmjUNwhJ6tqgcd0l7i2fDpyKp3WZlK/J3bFqiptDqZEhscCRES2 NWvYyPr02rFZV2fhwK26+p3v1viIJTajPF59U2bWQYrzQ53ote0tQqY8kLhN4oZbjeQO bWtweB34MvLdZarKsjtCMdgN4mJ2PEJ3MFvZYq9x4LOtId/KS42HlUUzosFOKLEPlJJJ eb4M8m7kD/mo83ymWXeFTeCgay65yiUnTvOkD1/bIdMBsoJxtt2tUmlDSiwo8fDSHdBm oQqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6Lys2W6r4uZ+JX1Onj0nOj2DyGILV+GiicWVaaDTbhY=; b=PLqusE2mzyoFfViWxfAKtrWFtnIuPEmfMkR0//0hOsX/EJ0fLNV/cV/02gsFg8xQoP xTndFEZrOYG3BSrA5p4tUWdF1AR6P0M6k5B80f7v03IGu9gvu4rRC+94w1wFycQxfJqf Fs+RrTISHuSzuIxtjlnkHwmuQLm/hgJhdRaQXRVVapI6WAIzFdiidhJWiNoiddrlKJqD Dm9gv+ZdTF9+Zxq8a/u4shjH5mEnj64aRD9M0p6nMNvnC5Ce9vGPFppo2WpQDQ+VHpQ8 UH40Og+UyiSx7VCBlOOpN8kCd5cGI4zi7XU08jHpsecuHleToIO2u3TLxOAlFnuLMrW6 tmeg== X-Gm-Message-State: AOAM530bnFiZmlHxo0lp/89O2znGGfqwlrjCQkDGSnJ3G1bKPwxXcrHZ HZYbaYEM1Je2eKyaWFyqVnzuaQOE7vk= X-Received: by 2002:a19:e03:: with SMTP id 3mr902474lfo.488.1601476889348; Wed, 30 Sep 2020 07:41:29 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id e14sm175616ljp.15.2020.09.30.07.41.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Sep 2020 07:41:28 -0700 (PDT) Subject: Re: [PATCH v3 1/3] memory: tegra: Add devm_tegra_get_memory_controller() To: Nicolin Chen , thierry.reding@gmail.com, joro@8bytes.org, krzk@kernel.org Cc: vdumpa@nvidia.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20200930084258.25493-1-nicoleotsuka@gmail.com> <20200930084258.25493-2-nicoleotsuka@gmail.com> From: Dmitry Osipenko Message-ID: Date: Wed, 30 Sep 2020 17:41:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200930084258.25493-2-nicoleotsuka@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... > +struct tegra_mc *devm_tegra_get_memory_controller(struct device *dev) > +{ > + struct platform_device *pdev; > + struct device_node *np; > + struct tegra_mc *mc; > + int err; > + > + np = of_find_matching_node_and_match(NULL, tegra_mc_of_match, NULL); > + if (!np) > + return ERR_PTR(-ENOENT); > + > + pdev = of_find_device_by_node(np); > + of_node_put(np); > + if (!pdev) > + return ERR_PTR(-ENODEV); > + > + mc = platform_get_drvdata(pdev); > + if (!mc) { > + put_device(mc->dev); This should be put_device(&pdev->dev). Please always be careful while copying someones else code :)