Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4627188pxk; Wed, 30 Sep 2020 07:48:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxM2m+HnGV9YXdFp6iZHl67PQRGtpydkwiHkxCP/aVympBtadWSZfjkxmDhQtStWwf+VzcT X-Received: by 2002:aa7:dd01:: with SMTP id i1mr3124339edv.121.1601477287407; Wed, 30 Sep 2020 07:48:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601477287; cv=none; d=google.com; s=arc-20160816; b=LJCba6ZY6NVzglho2c85Ml3RlYFWEYPboza3vQL/WuNlJQHwIF0XvRAE+7xXsRVD+9 Ft1wjXAH67bVtFyz3hAq5C1qwRJBz3khliZKTJf27b0GbiTSd2IGg0Ra9ysWcHx/lBa8 28l32mMJieVYpczIZW//urklbjGHMBeUy+sSyFplhvAUeyhMbEQmEGVbVw434nBjgCGq FBFC2m9Edd1ermxFyp9lNypRRIxnslSE4KY/XhnrcYSQoOWJ76zaCRY3Pvxwd+EMabJz lhQATsYQQ5PeLcmHmf8fEXddha3mJREw5/XhmBtKE65gJtCW8qYPhFlSIvRIYed39+Ir 1NSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SY+4lzFIJdAUtTUGhwEoG4+Vizwq2pLJHiggpdYY6L4=; b=mszPOgGPcI3hIL3F0KiFf5HCyvxIhdW9u40RHZo0D8K6FZLPY5vL2+OlpDDjPJTpy8 6D20QjLLoMFsLM4baSD56xherg01Zx2FB0cdaUeAJ7fuP56XF/CC1LaKDz9kFr3UgRVe lVukjQGBwKQnuskh9hJY6I/rPnlVkd0XOKJU6W/tpkSzlAyehS066ACDPpUaGssS7q2X 1dV/QHxB+tzfzi3r+dUwNyuCAe+AQVTYb7fajOiPronNNau0MHhBfP/JCZg0+IkBSfbn zSAiKoxWpE3HccW1eXHOnZb5GbWH0KcCJ4paKEAMOO4shwFUIcAMRw1yPfYv44TOmqsR OJGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si1193865edx.325.2020.09.30.07.47.44; Wed, 30 Sep 2020 07:48:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730651AbgI3Oqh (ORCPT + 99 others); Wed, 30 Sep 2020 10:46:37 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:29453 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728496AbgI3Oqh (ORCPT ); Wed, 30 Sep 2020 10:46:37 -0400 Received: from tomoyo.flets-east.jp ([153.230.197.127]) by mwinf5d69 with ME id aEmH2300J2lQRaH03EmS5y; Wed, 30 Sep 2020 16:46:33 +0200 X-ME-Helo: tomoyo.flets-east.jp X-ME-Auth: bWFpbGhvbC52aW5jZW50QHdhbmFkb28uZnI= X-ME-Date: Wed, 30 Sep 2020 16:46:33 +0200 X-ME-IP: 153.230.197.127 From: Vincent Mailhol To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" Cc: Vincent Mailhol , Jakub Kicinski , Oliver Neukum , Greg Kroah-Hartman , Arunachalam Santhanam , Masahiro Yamada , linux-usb@vger.kernel.org (open list:USB ACM DRIVER) Subject: [PATCH v2 0/6] can: add support for ETAS ES58X CAN USB Date: Wed, 30 Sep 2020 23:45:27 +0900 Message-Id: <20200930144602.10290-1-mailhol.vincent@wanadoo.fr> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200926175810.278529-1-mailhol.vincent@wanadoo.fr> References: <20200926175810.278529-1-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The purpose of this patch series is to introduce a new CAN USB driver to support ETAS USB interfaces (ES58X series). During development, issues in drivers/net/can/dev.c where discovered, the fix for those issues are included in this patch series. We also propose to add two helper functions in include/linux/can/dev.h which we think can benefit other drivers: get_can_len() and can_bit_time(). The driver indirectly relies on https://lkml.org/lkml/2020/9/26/251 ([PATCH] can: raw: add missing error queue support) for the call to skb_tx_timestamp() to work but can still compile without it. *Side notes*: scripts/checkpatch.pl returns 4 'checks' findings in [PATCH 5/6]. All those findings are of type: "Macro argument reuse 'x' possible side-effects?". Those arguments reuse are actually made by calling either __stringify() or sizeof_field() which are both pre-processor constant. Furthermore, those macro are never called with arguments sensible to side-effects. So no actual side effect would occur. ChangeLog: v2: - Fixed -W1 warnings in PATCH 5/6 (v1 was tested with GCC -WExtra but not with -W1). - Added lsusb -v information in PATCH 6/6 and rephrased the comment. - Take care to put everyone in CC of each of the patch of the series (sorry for the mess in v1...) Vincent Mailhol (6): can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context can: dev: add a helper function to get the correct length of Classical frames can: dev: __can_get_echo_skb(): fix the return length can: dev: add a helper function to calculate the duration of one bit can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces usb: cdc-acm: add quirk to blacklist ETAS ES58X devices drivers/net/can/dev.c | 26 +- drivers/net/can/usb/Kconfig | 9 + drivers/net/can/usb/Makefile | 1 + drivers/net/can/usb/etas_es58x/Makefile | 3 + drivers/net/can/usb/etas_es58x/es581_4.c | 559 ++++ drivers/net/can/usb/etas_es58x/es581_4.h | 237 ++ drivers/net/can/usb/etas_es58x/es58x_core.c | 2725 +++++++++++++++++++ drivers/net/can/usb/etas_es58x/es58x_core.h | 700 +++++ drivers/net/can/usb/etas_es58x/es58x_fd.c | 648 +++++ drivers/net/can/usb/etas_es58x/es58x_fd.h | 243 ++ drivers/usb/class/cdc-acm.c | 11 + include/linux/can/dev.h | 38 + 12 files changed, 5186 insertions(+), 14 deletions(-) create mode 100644 drivers/net/can/usb/etas_es58x/Makefile create mode 100644 drivers/net/can/usb/etas_es58x/es581_4.c create mode 100644 drivers/net/can/usb/etas_es58x/es581_4.h create mode 100644 drivers/net/can/usb/etas_es58x/es58x_core.c create mode 100644 drivers/net/can/usb/etas_es58x/es58x_core.h create mode 100644 drivers/net/can/usb/etas_es58x/es58x_fd.c create mode 100644 drivers/net/can/usb/etas_es58x/es58x_fd.h -- 2.26.2