Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154AbWHGRU0 (ORCPT ); Mon, 7 Aug 2006 13:20:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932176AbWHGRU0 (ORCPT ); Mon, 7 Aug 2006 13:20:26 -0400 Received: from mx1.redhat.com ([66.187.233.31]:4751 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932154AbWHGRUZ (ORCPT ); Mon, 7 Aug 2006 13:20:25 -0400 Date: Mon, 7 Aug 2006 13:19:58 -0400 From: Dave Jones To: Andi Kleen Cc: virtualization@lists.osdl.org, Rusty Russell , Andrew Morton , Linux Kernel Mailing List , Chris Wright Subject: Re: [PATCH 2/4] x86 paravirt_ops: paravirt_desc.h for native descriptor ops. Message-ID: <20060807171958.GT13393@redhat.com> Mail-Followup-To: Dave Jones , Andi Kleen , virtualization@lists.osdl.org, Rusty Russell , Andrew Morton , Linux Kernel Mailing List , Chris Wright References: <1154925835.21647.29.camel@localhost.localdomain> <200608070740.23840.ak@muc.de> <1154937040.7642.31.camel@localhost.localdomain> <200608071053.28293.ak@muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608071053.28293.ak@muc.de> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1891 Lines: 40 On Mon, Aug 07, 2006 at 10:53:28AM +0200, Andi Kleen wrote: > On Monday 07 August 2006 09:50, Rusty Russell wrote: > > On Mon, 2006-08-07 at 07:40 +0200, Andi Kleen wrote: > > > On Monday 07 August 2006 06:45, Rusty Russell wrote: > > > > Unfortunately, due to include cycles, we can't put these in > > > > paravirt.h: we use a separate header for these. > > > > > > > > The implementation comes from Zach's [RFC, PATCH 10/24] i386 Vmi descriptor changes: > > > > > > > > Descriptor and trap table cleanups. Add cleanly written accessors for > > > > IDT and GDT gates so the subarch may override them. Note that this > > > > allows the hypervisor to transparently tweak the DPL of the descriptors > > > > as well as the RPL of segments in those descriptors, with no unnecessary > > > > kernel code modification. It also allows the hypervisor implementation > > > > of the VMI to tweak the gates, allowing for custom exception frames or > > > > extra layers of indirection above the guest fault / IRQ handlers. > > > > > > Nice cleanup. The old assembly mess was ripe to be killed for a long time. > > > > OK, here's that patch extracted out. > > Is there something wrong with your mailer? This one doesn't apply either: Looks like it's against Linus' tree, not whatever you were trying against... (13:19:10:davej@nwo:linux-2.6)$ cat ~/rusty | patch -p1 --dry-run patching file arch/i386/kernel/traps.c Hunk #1 succeeded at 1116 (offset 4 lines). Hunk #3 succeeded at 1132 (offset 4 lines). patching file include/asm-i386/desc.h (13:19:15:davej@nwo:linux-2.6)$ Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/