Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4654391pxk; Wed, 30 Sep 2020 08:23:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuXs84UorZx7kH5sGKGl9mfIpz0kGDYywFEcGHFjvTjn1wmdiehBA3smruSFBHxAlW+7cv X-Received: by 2002:a17:906:14ca:: with SMTP id y10mr3280513ejc.542.1601479415987; Wed, 30 Sep 2020 08:23:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601479415; cv=none; d=google.com; s=arc-20160816; b=AmYGDjsFqEHfWVLWCKrfTU+fKmxv27L1MwmjK7njf/MNK7oj1shDtzkBh0LPcFyh61 aGteLmqdO7NUgy4tpqhgSijz8FjGGyckr+TaY3+zgpFHIFHily04Q7IcZKeC2rrgSwZ0 uZo3/jI6XC24/n3ncTEJFOA/WNegJicWbkaSzfNkekJ2Q22FLEIwa8O5yBW5OSvUxuoY /ZG7xlALOHYJ+LMappFN8V0BdtBDeE6HNipDqelFMAZrVox/on5jf++fy1KqNsnV5TNa KKzeWoAwu0mzkphb1iNydqYjA9sWcm58l4AVUPFxzOT6VKlUwr45RUoy1H0dmszAIuvF M4Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JJ2ag1Mmh5kTbyFCESLoQcAb1qiI9vhyzO9OqzkURbo=; b=OtjlLnQHz7SJ5cwP8MWJkUuhRzmyQ1V6gJI1rs0qEOFa3LpdKNP+k9oyfcJVXsPUGW 4ls5PUS6ZjfJinOvrtbmsqRaiyIO4EWBYksrSca39rxYVfpfuspotQ8q1sqyLVD2z/Me ODFKTfAdeMMLL9Nc4fEJn9cBivkzrS7uB+m1WKTzW12ECksWU+3vZ5q9cvRz1ZkWPIUE ZpII7vPjcvVGWhuUOJBUOsKN5G1PSzZY234xHidyJ3KZzivUtbBqIoU7h7toKBYSWkm9 lfE+MBL1rSq4UR6f0Nfy7KUY6l7LuHYglm5Ue8KhJWLaH7LsBDQQD45thUKdI1KC/7kR fgrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dVqvwNDm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si1395737ejt.59.2020.09.30.08.23.12; Wed, 30 Sep 2020 08:23:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dVqvwNDm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728329AbgI3PUB (ORCPT + 99 others); Wed, 30 Sep 2020 11:20:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36190 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgI3PUA (ORCPT ); Wed, 30 Sep 2020 11:20:00 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601479200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JJ2ag1Mmh5kTbyFCESLoQcAb1qiI9vhyzO9OqzkURbo=; b=dVqvwNDmi407ppMVxpRv2JwMlFUgYSRcdApMIU+M5lxxwuZu8odXbI5vh7OaoJZNaG6NBe pRAKctO2iXKNC9LKmnZQ9YBgxwmSDqMxSnfEUbgA+OxjqON0jpUKJqjPGcOsip0vPL6nEw t4clJUhiacl/laASkWeCrKnVrcebmU0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-RTStyAFnN_KnrobJwcHY9g-1; Wed, 30 Sep 2020 11:19:58 -0400 X-MC-Unique: RTStyAFnN_KnrobJwcHY9g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B4BC80734F; Wed, 30 Sep 2020 15:19:56 +0000 (UTC) Received: from treble (ovpn-120-207.rdu2.redhat.com [10.10.120.207]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B35C760DA0; Wed, 30 Sep 2020 15:19:53 +0000 (UTC) Date: Wed, 30 Sep 2020 10:19:51 -0500 From: Josh Poimboeuf To: Vasily Gorbik Cc: Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Miroslav Benes , Alexandre Chartre , Julien Thierry , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 1/2] objtool: x86 instruction decoder and big endian cross compiles Message-ID: <20200930151951.wwsleh6m4buybqhf@treble> References: <20200930101251.GX2628@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2020 at 02:24:19PM +0200, Vasily Gorbik wrote: > From: Martin Schwidefsky > > Make the x86 instruction decoder of the objtool usable on big endian > machines. This is useful for compile tests on non x86, big endian > hardware. > > Co-developed-by: Vasily Gorbik > [ gor: more endianness problems findings fixes / rebasing ] > Signed-off-by: Martin Schwidefsky > Signed-off-by: Vasily Gorbik > --- > arch/x86/include/asm/insn.h | 42 ++++++++++++++ > arch/x86/lib/insn.c | 95 +++++++++++++------------------ > tools/arch/x86/include/asm/insn.h | 42 ++++++++++++++ > tools/arch/x86/lib/insn.c | 95 +++++++++++++------------------ > tools/objtool/arch/x86/special.c | 2 +- > tools/objtool/check.c | 4 +- > tools/objtool/elf.c | 34 ++++++----- > 7 files changed, 188 insertions(+), 126 deletions(-) Can the insn changes be done in a separate patch from the objtool changes? Also, 'Masami Hiramatsu ' should be on Cc for the insn changes since he wrote the original code. -- Josh