Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 30 Sep 2020 17:23:20 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Nicolin Chen <nicoleotsuka@gmail.com>
Cc:     joro@8bytes.org, krzk@kernel.org, digetx@gmail.com,
        vdumpa@nvidia.com, jonathanh@nvidia.com,
        linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] memory: tegra: Add
 devm_tegra_get_memory_controller()
Message-ID: <20200930152320.GA3833404@ulmo>
References: <20200930084258.25493-1-nicoleotsuka@gmail.com>
 <20200930084258.25493-2-nicoleotsuka@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="/9DWx/yDrRhgMJTb"
Content-Disposition: inline
In-Reply-To: <20200930084258.25493-2-nicoleotsuka@gmail.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--/9DWx/yDrRhgMJTb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 30, 2020 at 01:42:56AM -0700, Nicolin Chen wrote:
> From: Dmitry Osipenko <digetx@gmail.com>
>=20
> Multiple Tegra drivers need to retrieve Memory Controller and hence there
> is quite some duplication of the retrieval code among the drivers. Let's
> add a new common helper for the retrieval of the MC.
>=20
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
>=20
> Changelog
> v2->v3:
>  * Replaced with Dimtry's devm_tegra_get_memory_controller()
> v1->v2:
>  * N/A
>=20
>  drivers/memory/tegra/mc.c | 39 +++++++++++++++++++++++++++++++++++++++
>  include/soc/tegra/mc.h    | 17 +++++++++++++++++
>  2 files changed, 56 insertions(+)

Let's not add this helper, please. If a device needs a reference to the
memory controller, it should have a phandle to the memory controller in
device tree so that it can be looked up explicitly.

Adding this helper is officially sanctioning that it's okay not to have
that reference and that's a bad idea.

Thierry

--/9DWx/yDrRhgMJTb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl90ouUACgkQ3SOs138+
s6G0NA/+JtP7HDf54k4WLttD9PHeHmArpo9ZQ9Cih4NUP5xCKMD3bmzowtvSTGJ8
xPvIdl9O855MlxNNauh+7cXg3nDvn85BUCNaMKtAzVQ30BtXWB95H7QhFVG2Kbgd
+evbfXFPrpqaWBZ6egGauexDgTfefBKtOypZz7aof4auiUHpKGooSheje97iA9b5
+aof5Hr8iZUgr26RreE/zS0YzcqSG90mGMHt6gSOi1YYh53MIIjMz9wqWIar3CoI
Tf0K6GdsuYfEnNPaANj0QGyX56MIN/rxHS8t4pc3wa626ZDIr4Lbqbub2X2bqfph
VzqnbHp6pKJlF14Vl9kBMALzuozE2YQPzNGXPmx0atTx6D7CMemh1lDEgl9s6jOY
xLkGXaaXxeuAG7uRpjl5e/ZvKcZPAo/5h7e1rVI7YzqT8fOQFutSnIee7OtUJn1I
NofIhug9Nr2AACZedAO/ogsi6OzKpCGisFSA5u/QNf4oo+428a9kNgmgPUtye1AP
Bs63Kyo3FC45T8qOGbh3Fq/+PmutQ5jrxZ4GvlzkFrEvNi4jF92eIpPbqkw/g+SO
r/mfCXbnb9D3wnqhxP54A4HD+7vAN5idvQwx7WORs4bOMmH1+n/FazDn/Cc2uVqS
rV3XsDxoezc0DG8Rw+fsIY2ni4j23qLwTnyZGkSt/3gI9g9LM4M=
=56Ae
-----END PGP SIGNATURE-----

--/9DWx/yDrRhgMJTb--