Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4656779pxk; Wed, 30 Sep 2020 08:26:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvCQSRuEFiSh/6Aj0y00yFXkD7nwTza6FJEJlhWa4WhUnZ4KBTb2xp+wVz0pVkFIpItbLd X-Received: by 2002:a05:6402:2076:: with SMTP id bd22mr1445729edb.197.1601479602799; Wed, 30 Sep 2020 08:26:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601479602; cv=none; d=google.com; s=arc-20160816; b=VAaeyf51c+NL0+8+tqEgFhB+Qz8VXQCLePRH5/arFIOod4kO3sFoKGyY5e8+cjyBmW b0rS/vRPwQYQFK/CiBfw1438W6PxtZGhHq6ox50rBzGybUKk6weqi+EEE4BF3bi3PXTf xC5fSiyq5ikUlyANphY35vD1m6v1KpaUlXYza/r+eJjSuzbtP+JxCXxu6N03dYJhV1Ke gQbExEQugGCj3bKJHFHBhq0XtWBU8YluJSoqUO14xz7tZgl6SzmjrceOAmjiRkq+8cA+ BcBeeNKGMiPQ+lTYOM/89A6UysdYJsYuIaUNyPwHRzKDllBdt0EAFFS5mJiTmLTogPAk Xk8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xCd+oCgv7oAd+34p0BYKsp9wxKF5wq3oIEDSZ6JHbPA=; b=UOJGTtOsfHgf1zYD57uYJ9bIA48J6Xxxp+hzmmTuaZ92CIiJmClZO4FAcEz17BYLWJ Zj39wZzzqxotZxPW+bpEz7pr0qWsqVmz2bJOj+vM53grA2SLfoavUXTd3DEuccu0qXAh ik9bRiKtZbGHG7FZ2XYEBrQj6AbV1IDPYBJLM4h38dUg2kaY0bBq+VUnmOQDaSb6KlgQ GbAyGwakycstQPESlU6Tb8Ym6cL05Ct1Mzn5CVe0sVbXuWmLpQzyOqxOGVZDZYAzLSL1 2e1pRLUSt3Hs1SjDCxcQLZ4xl1/PJsZooGkMGClgRLtiu70Dz6qN+965zjx2LvIY6yuX TL0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=JzWqktQe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u17si1256820edr.266.2020.09.30.08.26.18; Wed, 30 Sep 2020 08:26:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=JzWqktQe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725385AbgI3PZX (ORCPT + 99 others); Wed, 30 Sep 2020 11:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbgI3PZT (ORCPT ); Wed, 30 Sep 2020 11:25:19 -0400 Received: from mail-qv1-xf41.google.com (mail-qv1-xf41.google.com [IPv6:2607:f8b0:4864:20::f41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD126C0613D0 for ; Wed, 30 Sep 2020 08:25:19 -0700 (PDT) Received: by mail-qv1-xf41.google.com with SMTP id q10so1087544qvs.1 for ; Wed, 30 Sep 2020 08:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xCd+oCgv7oAd+34p0BYKsp9wxKF5wq3oIEDSZ6JHbPA=; b=JzWqktQe2JPtx5T9AJC7N/S7gcKe7i+bQDBtIDqxoUCCr/aCiMKBFfnEXyTuBv7+kS 3kBpse8b1y9++0M+YX/b5PlR7Cjol7fPh3EARvLtGBxWXa4s0U2Sbcq7679fl03EEdoI Wdi7CrxlTz/BXfg9dbu1WNTuLcKYipGbyifyw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xCd+oCgv7oAd+34p0BYKsp9wxKF5wq3oIEDSZ6JHbPA=; b=e/rLbdhpd+ZadNYQ3d4bi3qY9R8DFVigy5dUoMCiV3GUkghEuCHEjvNCzPT/dhGpSd oNqHz4PBVx8pJGRz8pL64AESJ6a21HDXBil0NraVSTmFKZrGepFaVzEFLgr+vEn0+F+0 vKpVPwNMWndBLf1DxdQ2i1nQFFMzz/bSeJr4xZ5ONYhxJmakgB5yIHAYKvJZv4/J3lK3 ytURh4ahAYIA1lRqTGxoZOGv+YQYJk3Ysqupdp4QraSs5JFsatKC1LONoU6l2wjpgfXP jVpsWMqxzXHPHj+Jm7yKX3jCA7n39kLEOcjpEoc8D3qraUfBIoWz5T0xsUJzcbmDsB0r 0fiA== X-Gm-Message-State: AOAM532U1R1wdJsF2+ynRV+ZftLq5C+A/ZtH7r9YyufDd4E9v5udVzfQ AY3GfCvAtl4QwLu02hrhq3p8OQ== X-Received: by 2002:a0c:e2c1:: with SMTP id t1mr3092219qvl.35.1601479518915; Wed, 30 Sep 2020 08:25:18 -0700 (PDT) Received: from localhost ([2620:15c:6:12:cad3:ffff:feb3:bd59]) by smtp.gmail.com with ESMTPSA id v15sm2350950qkg.108.2020.09.30.08.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 08:25:17 -0700 (PDT) Date: Wed, 30 Sep 2020 11:25:17 -0400 From: Joel Fernandes To: Michal Hocko Cc: Uladzislau Rezki , Mel Gorman , "Paul E. McKenney" , LKML , RCU , linux-mm@kvack.org, Andrew Morton , Peter Zijlstra , Vlastimil Babka , Thomas Gleixner , "Theodore Y . Ts'o" , Sebastian Andrzej Siewior , Oleksiy Avramchenko , Mel Gorman Subject: Re: [RFC-PATCH 2/4] mm: Add __rcu_alloc_page_lockless() func. Message-ID: <20200930152517.GA1470428@google.com> References: <20200921194819.GA24236@pc636> <20200922075002.GU12990@dhcp22.suse.cz> <20200922131257.GA29241@pc636> <20200923103706.GJ3179@techsingularity.net> <20200923154105.GO29330@paulmck-ThinkPad-P72> <20200923232251.GK3179@techsingularity.net> <20200924081614.GA14819@pc636> <20200925080503.GC3389@dhcp22.suse.cz> <20200925153129.GB25350@pc636> <20200925154741.GI3389@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925154741.GI3389@dhcp22.suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 05:47:41PM +0200, Michal Hocko wrote: > On Fri 25-09-20 17:31:29, Uladzislau Rezki wrote: > > > > > > > > > > > > All good points! > > > > > > > > > > > > On the other hand, duplicating a portion of the allocator functionality > > > > > > within RCU increases the amount of reserved memory, and needlessly most > > > > > > of the time. > > > > > > > > > > > > > > > > But it's very similar to what mempools are for. > > > > > > > > > As for dynamic caching or mempools. It requires extra logic on top of RCU > > > > to move things forward and it might be not efficient way. As a side > > > > effect, maintaining of the bulk arrays in the separate worker thread > > > > will introduce other drawbacks: > > > > > > This is true but it is also true that it is RCU to require this special > > > logic and we can expect that we might need to fine tune this logic > > > depending on the RCU usage. We definitely do not want to tune the > > > generic page allocator for a very specific usecase, do we? > > > > > I look at it in scope of GFP_ATOMIC/GFP_NOWAIT issues, i.e. inability > > to provide a memory service for contexts which are not allowed to > > sleep, RCU is part of them. Both flags used to provide such ability > > before but not anymore. > > > > Do you agree with it? > > Yes this sucks. But this is something that we likely really want to live > with. We have to explicitly _document_ that really atomic contexts in RT > cannot use the allocator. From the past discussions we've had this is > likely the most reasonable way forward because we do not really want to > encourage anybody to do something like that and there should be ways > around that. The same is btw. true also for !RT. The allocator is not > NMI safe and while we should be able to make it compatible I am not > convinced we really want to. > > Would something like this be helpful wrt documentation? > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 67a0774e080b..9fcd47606493 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -238,7 +238,9 @@ struct vm_area_struct; > * %__GFP_FOO flags as necessary. > * > * %GFP_ATOMIC users can not sleep and need the allocation to succeed. A lower > - * watermark is applied to allow access to "atomic reserves" > + * watermark is applied to allow access to "atomic reserves". > + * The current implementation doesn't support NMI and other non-preemptive context > + * (e.g. raw_spin_lock). I think documenting is useful. Could it be more explicit in what the issue is? Something like: * Even with GFP_ATOMIC, calls to the allocator can sleep on PREEMPT_RT systems. Therefore, the current low-level allocator implementation does not support being called from special contexts that are atomic on RT - such as NMI and raw_spin_lock. Due to these constraints and considering calling code usually has no control over the PREEMPT_RT configuration, callers of the allocator should avoid calling the allocator from these cotnexts even in non-RT systems. thanks! - Joel > * > * %GFP_KERNEL is typical for kernel-internal allocations. The caller requires > * %ZONE_NORMAL or a lower zone for direct access but can direct reclaim. > > [...] > -- > Michal Hocko > SUSE Labs