Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4732953pxk; Wed, 30 Sep 2020 10:14:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5eRvcRZYmf9xifJJn4zukzzKl7mGyWxDkMa32EhWMV1U4uy7gJ8AbT9GdbZU1FoqVndjC X-Received: by 2002:a17:906:2301:: with SMTP id l1mr3729454eja.488.1601486040745; Wed, 30 Sep 2020 10:14:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601486040; cv=none; d=google.com; s=arc-20160816; b=hQzuWuQEyDRiVf71Z4Ngl1SS/O253Sofxl9qkaJEwwZx96askW6ZmHdH+BoDP/t3eZ pocJchA+u70jNQtR6jUlPmoryjiVunnQDv+44owDfYpt36zIBejUDGhrUsoYEoaR7g89 RbeaBVrdHjnXIBsNKASN+IFeTo9kJykhIsNq6hZz8iFtC/EHT3lBtivsNoKpZteHUofZ RE9UCrg0azuqya3gmYWTbacJGOQHHzRPpqII9PnM6uHlwnZE1H31MuFs+uVOCqpofyG0 tWmPu+63vyFvOdiGLdU9Iah3I/m9f3HaE/X1Jk8ytR2ZJ3ugPk368txaiMEg0L4PIVkr Yz7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=9a10Xq7dvaF1eyP7k2mHciZLnxaJ8aKVVi91LPo8t70=; b=VaW/IyTyBEd7RIX8T6y448ejrdW5jf6MeCDvmLt6I288QBkXYcfD4otXN4CyP5E1+u F+YmpweNObQl0sHCHsFQici12wMTqyxyt8lKi5EG5GUlZJUq/8pSnR4Kj+8u1h3kMJyF O44tQ+3oF3l45SM9wyEa/tcZf0D9qFQ08x7QeXwiPLbf0bxKy4JlCsMBXJz4v5R7OskK QHKAa5MPxs9veM6w/k8k2N3CpoGZNMoHCl5pBaM9SKLcvDzQnJOFGZq96FBiSsBUJXRt EgrKkoSYsmwijaxQSXMOMg2PINu8wckK5LQP2lqYGxgAwIXxE8zF/RjEQuKhSZABOJGy 8xEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si1606244ejc.703.2020.09.30.10.13.37; Wed, 30 Sep 2020 10:14:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731335AbgI3RLw (ORCPT + 99 others); Wed, 30 Sep 2020 13:11:52 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:57188 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgI3RLw (ORCPT ); Wed, 30 Sep 2020 13:11:52 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 4CA231C0B81; Wed, 30 Sep 2020 19:11:48 +0200 (CEST) Date: Wed, 30 Sep 2020 19:11:47 +0200 From: Pavel Machek To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Tobias Jordan , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , Jean-Jacques Hiblot , Tomi Valkeinen Subject: Re: [PATCH v2] leds: tlc591xx: fix leak of device node iterator Message-ID: <20200930171147.GG27760@duo.ucw.cz> References: <20200926005117.GA32209@agrajag.zerfleddert.de> <20200926032406.00c7cfb2@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="doKZ0ri6bHmN2Q5y" Content-Disposition: inline In-Reply-To: <20200926032406.00c7cfb2@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --doKZ0ri6bHmN2Q5y Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > In one of the error paths of the for_each_child_of_node loop in > > tlc591xx_probe, add missing call to of_node_put. > >=20 > > Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the > > managed led API") > >=20 > > Signed-off-by: Tobias Jordan >=20 > Reviewed-by: Marek Beh=FAn Thanks, applied. Marek: Thanks for review. If I can get you to trim parts not interesting for the email, I'll be even happier. :-). Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --doKZ0ri6bHmN2Q5y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX3S8UwAKCRAw5/Bqldv6 8sGjAJ4p4WWc5e3h1dnOH15zoZ6BkKqEuwCgj4CZR2QoQTFl1EemE7FZu+L781s= =2qtW -----END PGP SIGNATURE----- --doKZ0ri6bHmN2Q5y--