Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4789649pxk; Wed, 30 Sep 2020 11:42:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwg55IiTP8wVfmbNwnutUXhg7KVRfNPdj8ar4Y805ThE10/TVMSY5oFFPfYpP+PaQ8/Wlnq X-Received: by 2002:a17:906:7b87:: with SMTP id s7mr4225880ejo.328.1601491371763; Wed, 30 Sep 2020 11:42:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601491371; cv=none; d=google.com; s=arc-20160816; b=iBmnUgYCPfQTL1qv4Kn2HbuXFhPTEEffVlt+YIwfXas23/EOJGLJDlw1ZThVMCD3jv jkLKpIe94KTvONTP629A5nD2xvMhNfBdaBGq9EWVIlNQC1a473FNDG2jMwXsnWGvrXk6 z0g2XB2LQqN4SnNTWTnrTu6CGMZAQ7++uPx0CkerShmB56kqa1nGympkk+GrdVznBrKa +qGRnV/zZPz5Umjq+qlbjtV1AhWx43Y+hxS7Rc1RwNi2/FvDyvleqiPrZkFcD8/zfk7D Z2MQaYzKJ8m6bFL2QbS4rH9jUFmRf2Z5Z4tPEbT/xTZR8zzTjUfrMu+f7tirLAnd1x2a 0FKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=rQ2duNt2s6+L7rL4IM/3ekbm5IY+okCkg4LO2ApNXic=; b=rtfGCryune8zsOEi7i9JgtG0N0Q9bob3estZZujLFRhNVYuaR+LRwEJNdE2fcGuxEv VHEesjyZ4fpS72fzGEeVh752ca3fjO60I/rmTmdoeFdnKBPxao4ZbXxoTXcm+kQz0crW Z6bCF4nxR78xUpPEzDs8ZVntI0NAk8FVhTEmm3W5uKimV054vA96YFxgveWO8lqufC61 oXUzfEaBjH6LvRbbn+FfTasb+43aNQUD2lp1fy8SczzQ81gVLxd7TQ+jiMBkHi+F45nM KKU1qxb/uK/2q+tNSwVhXO+PsB7En4zRb3LuVpne61QqEcE5Dj0TiesUY7mx8Y1mcIEW I3iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RO7cijZt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d26si2005247ejy.107.2020.09.30.11.42.29; Wed, 30 Sep 2020 11:42:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RO7cijZt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729872AbgI3Sk5 (ORCPT + 99 others); Wed, 30 Sep 2020 14:40:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:52804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726476AbgI3Sk4 (ORCPT ); Wed, 30 Sep 2020 14:40:56 -0400 Received: from localhost.localdomain (c-98-220-232-140.hsd1.il.comcast.net [98.220.232.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7624B2076B; Wed, 30 Sep 2020 18:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601491256; bh=ZqpDxEO3m0DRyyJc48yncKEqA34Tu2F7H7OjlL1kqkk=; h=From:To:Cc:Subject:Date:From; b=RO7cijZtUkR4e1o5iEcDFHZZJAUa1nN8vM8X7kpGEibrbsbJpGNoN8D0CUDzvUSQM v31YvXdKkrHSjW01nU6O+Ssvx9peySteLRO/jIUgIRoAqz3BOVX5u9uyy0qg6k6af4 Z/6LBqcye2/uyucSXDtDXe77AcW2JARdrFr88TQ4= From: Tom Zanussi To: rostedt@goodmis.org, axelrasmussen@google.com Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] tracing: Add dynamic strings for synthetic events Date: Wed, 30 Sep 2020 13:40:49 -0500 Message-Id: X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This is v2 of the dynamic string support for synthetic events. v1 was missing some very important code in the in-kernel API functions that should have reserved room for dynamic strings. This adds it along also some additional test code in the synth_event_gen_test module that tests the dynamic strings for those APIs. I also added Axel's changelog text to the 'tracing: Fix parse_synth_field() error handling' patch and used ssize_t as he also suggested. Thanks, Axel! I also noticed that the original patch didn't use <= as it should have, so changed that as well. Neither my command-line tests or the synth_event_gen_test module are showing any problems at this point for me... Tom Original v1 text: This patchset adds support for dynamic strings for synthetic events, as requested by Axel Rasmussen. Actually, the first two patches should be applied in any case - the first just changes the current max string length and the second fixes a bug I found while testing. It works fine for my simple test cases, but I still need to do a lot more testing, especially of the in-kernel API parts, which don't affect Axel's use case. Anyway, Axel, please try it out and send me your Tested-by: if it works for you, and your broken testcase(s) if it doesn't. ;-) Thanks, Tom The following changes since commit 106c076d23cca67c959a6fd1ccadb5b3ef01ddc9: mmap_lock: add tracepoints around lock acquisition (2020-09-23 08:48:08 -0500) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/synth-dynstring-v2 Tom Zanussi (3): tracing: Change STR_VAR_MAX_LEN tracing: Fix parse_synth_field() error handling tracing: Add support for dynamic strings to synthetic events Documentation/trace/events.rst | 15 +- Documentation/trace/histogram.rst | 18 +++ kernel/trace/synth_event_gen_test.c | 18 ++- kernel/trace/trace_events_hist.c | 9 ++ kernel/trace/trace_events_synth.c | 243 ++++++++++++++++++++++++---- kernel/trace/trace_synth.h | 6 +- 6 files changed, 269 insertions(+), 40 deletions(-) -- 2.17.1