Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging
Thread-Topic: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging
Thread-Index: AQHWl2jkTeQqn7VGgU2tHQ+vhEtr46mBpgUA
Date:   Wed, 30 Sep 2020 20:43:59 +0000
Message-ID: <20200930204358.574xxijrrciiwh6h@skbuf>
References: <20200930203103.225677-1-f.fainelli@gmail.com>
In-Reply-To: <20200930203103.225677-1-f.fainelli@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B19DF3755EFF194BB9BB87738837FB09@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 710b5641-690a-4727-6fe3-08d865818f1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2020 20:43:59.7853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tgrDdCN7NOOHViVdIHSr4+D+hmC6gbxnKR6zpaOnGNO09WindIttLXJqjeKiGfAs3KclieHYCxC1EaPnfDT8bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6510
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 30, 2020 at 01:31:03PM -0700, Florian Fainelli wrote:
> While we are it, call __vlan_find_dev_deep_rcu() which makes use the
> VLAN group array which is faster.

Not just "while at it", but I do wonder whether it isn't, in fact,
called "deep" for a reason:

		/*
		 * Lower devices of master uppers (bonding, team) do not have
		 * grp assigned to themselves. Grp is assigned to upper device
		 * instead.
		 */

I haven't tested this, but I wonder if you could actually call
__vlan_find_dev_deep_rcu() on the switch port interface and it would
cover both this and the bridge having an 8021q upper automatically?=