Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4862065pxk; Wed, 30 Sep 2020 13:48:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbav69ZJmFMrJg/CH4mopBt+TMWpj0tauXBHjvTu0Is/m9Gl4JukCJ5KnAjTqhO01gkYD1 X-Received: by 2002:a05:6402:1515:: with SMTP id f21mr4943016edw.175.1601498920913; Wed, 30 Sep 2020 13:48:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601498920; cv=none; d=google.com; s=arc-20160816; b=xsyDKv74R/c54619k053mStnakUP80NGHx4QeRTevyfOG895gF0kyBudIfHO+uYmbn XR5JUc0pSeO1UiLv1Xp+XbdGkl4SAxwJfeL/RuapSy3r6nvMckBq0jpw8lRG6/udYaQR KpUKd567T51vXF3acOfmo372fCO6ypGAZknnhHflh/F57N1iuT0HqBT6nvsOSra4rOYt Vp0jErWz9ZNyGqspiyMh6k+LMOW12Tvnr7oQOdiOcyYhxf2UA9obGOvs41hVpJ0xi2pC u4971IdYSnyu9tPaNndfN2skGGrnEJvYKfL9V1yMCcVjKUjVR58hEz8w9iQ7h192eg34 XupA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JgQmmymEepmTyKfdtmZJjASTO5kyTURiWqToh5meDKE=; b=h6BLp8xdlcKLHTbiPc17yiZLCliNjxaJu2+gKBXgnLuur71W7Jx0IQQ/AEquDW6o2s R2ukzx2fZth2zqWdD092n0MDKEaPsfL6HNIVnREf4LRegR4v615nqa6Wu6TIfa66WedE wJJSGUWvMrHATksadxpE/wuev2bO/cnA/d+OBlIUMZPW7JNRDfW62A0ZWje4Fa4ZQPVX bJ/GpClTsw52wGVIDuqdLg3nZolFpFtDI6w5gSUSP0IDSuWaUpcyqqNFO/82RCQrnHKm 55BRsZ3fwvofPowIwBDe5oWpbhzAGjjTUvnB23iLi5b+tXg9P+q2glXvzyRSHCfP88O5 OB8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=N1JSnjgI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p9si1460809eja.248.2020.09.30.13.48.15; Wed, 30 Sep 2020 13:48:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=N1JSnjgI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730276AbgI3UpH (ORCPT + 99 others); Wed, 30 Sep 2020 16:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgI3UpG (ORCPT ); Wed, 30 Sep 2020 16:45:06 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A608BC0613D1 for ; Wed, 30 Sep 2020 13:45:06 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id s31so1868334pga.7 for ; Wed, 30 Sep 2020 13:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JgQmmymEepmTyKfdtmZJjASTO5kyTURiWqToh5meDKE=; b=N1JSnjgIbsN1xv7O/7f3T3QNscpYc+Oc8Onavg+xJhKmu87Vl5txC0mRnj581yP+T5 vji39GuQ54k3KnvTyItbHHJyjV7n/9yiIdpidKzXo0JDXhzi+h96aiFk9fi64j8d2bCt gMDMVPAGpbUo9icFxVDwyRsfPfCjPc7VT3l7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JgQmmymEepmTyKfdtmZJjASTO5kyTURiWqToh5meDKE=; b=IwSZs9tECB5jrrcN82ci2wAYF4S2+jsSZ4gVecvS9vaV7jTWZD2ClPrvnb0vM2IR8h ZEyJfYitfMs9dhnChn6Yva2LGkOCLtmH8QGfOPTBDOtXhVze8HvnQ6bALpOiD/+ba24R fnGwFxIOuuBUIc0YfuWulJJeUn6gZJXq4d8aXjtsN3Nr+4qBc+KNakrpgiGkoyj95F3s kov63WSMHxQ6FWQ7kea65IplBJkWpC+qeMPfejHFkb+SDQsqOdKwi+iEz/Fol8nRkcXJ 9c1PxyrINI8+48n/3FGkiHvgdr6mg4uN63ZNs+3zkoVL684GMI7ppFpXqxES6y6vWiTH CL8A== X-Gm-Message-State: AOAM532EIe9uJGD2SNu60MpT0KTjQrx8yfT8xbos3MF5eUw0gb9fJvFD 6ai+jL1yhBtUIsxuFN8hbyB6jw== X-Received: by 2002:a63:4d4a:: with SMTP id n10mr3430255pgl.96.1601498706030; Wed, 30 Sep 2020 13:45:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g24sm3730158pfk.65.2020.09.30.13.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 13:45:05 -0700 (PDT) Date: Wed, 30 Sep 2020 13:45:04 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Steven Rostedt , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 10/29] treewide: remove DISABLE_LTO Message-ID: <202009301344.3949D2FA8@keescook> References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-11-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929214631.3516445-11-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 02:46:12PM -0700, Sami Tolvanen wrote: > This change removes all instances of DISABLE_LTO from > Makefiles, as they are currently unused, and the preferred > method of disabling LTO is to filter out the flags instead. > > Suggested-by: Kees Cook > Signed-off-by: Sami Tolvanen Thanks! I think this makes things cleaner in the later patches. :) Reviewed-by: Kees Cook -- Kees Cook