Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp4864305pxk; Wed, 30 Sep 2020 13:53:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4zlzyGl6lGcTEXC71+iYLqUNKbHZZ8afoTdd8N2j2fYjHOQ2LGeTj00SQ/iFaQXnRazKQ X-Received: by 2002:a17:906:7d52:: with SMTP id l18mr4700253ejp.220.1601499205708; Wed, 30 Sep 2020 13:53:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601499205; cv=none; d=google.com; s=arc-20160816; b=uEv8haJzakxyMaOe6vGaAD/I6AoEe+D6hZ3bc6dikbf77MGXU2fwq6iR4NU2L61rMi zwiu8l1Y+q8/PNeVeZ0+TXhMOjAu0fXVSOTVXXG5SuOFQ1zjdaZcUm/NJ6NuJ0RZbAyV Wwd5PRFJa0KAEMwh7TTBy9gNUrrrZHkfKpyVscgzGF73GoKjPXaS1hEPpYFpd6iHfERZ 4Xm71aSqQ8k7BpmPi5iO5ooYaVWzeD2BP/Okzfk0MSAA8G8bQHGClSfuntW892d2ZXg7 IqneZvIln9gcOuPYJUDaI4hfi/EuH0pVYK5a5ggHOoppmCKNPX7RTLiw8oZjxLNVBU63 sI1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=bK0VTaAx8QNZOSp33QqpAg8ogqdOEMvsjgZhVAgVcsM=; b=Es+VAmzrzxTX/s3QwUBr5OMeSorXAcZWLxL9HaDqnKJ0onriGAzrlcjgHKiZUWRJCg nFfemKUk+jzVI2yXAF/m3cJcbTiDM6O8nZ7NFYdiHCGwLGatvNY4qN9RethLwxkFKjEe apje9sRF9Lh99GaA117fCPB4wnPBt4gdxFUMYsr9+Y/Z4QpQuZJezSufum/84sDETScY HOI/Fuk+dIk7apWEpX21NRT5qoUAEZu/mXG9U9nlopVv29M2mhafxODYXARMhpaJoVEn LWa3ihkN+q/iAHKEmYdtuA2a7roygxkbQvr/iFN+CBSWQ6NArDOUtmXAub/czQDPkqQF bOSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g9si1866406edy.513.2020.09.30.13.53.03; Wed, 30 Sep 2020 13:53:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729792AbgI3UwD (ORCPT + 99 others); Wed, 30 Sep 2020 16:52:03 -0400 Received: from agrajag.zerfleddert.de ([88.198.237.222]:57538 "EHLO agrajag.zerfleddert.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgI3UwD (ORCPT ); Wed, 30 Sep 2020 16:52:03 -0400 X-Greylist: delayed 441 seconds by postgrey-1.27 at vger.kernel.org; Wed, 30 Sep 2020 16:52:02 EDT Received: from denkmatte (unknown [5.182.90.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: knilch) by agrajag.zerfleddert.de (Postfix) with ESMTPSA id B75475B20134; Wed, 30 Sep 2020 22:44:40 +0200 (CEST) Date: Wed, 30 Sep 2020 22:44:39 +0200 From: Tobias Jordan To: Pavel Machek Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , Nikita Travkin Subject: Re: [PATCH] leds: aw2013: fix leak of device node iterator Message-ID: <20200930224439.0014c2dd@denkmatte> In-Reply-To: <20200930171017.GF27760@duo.ucw.cz> References: <20200925232644.GA17005@agrajag.zerfleddert.de> <20200930171017.GF27760@duo.ucw.cz> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.4 at agrajag X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-30 19:10, Pavel Machek wrote: Hi Pavel, > > In the error path of the for_each_available_child_of_node loop in > > aw2013_probe_dt, add missing call to of_node_put to avoid leaking > > the iterator. > > > > Fixes: 59ea3c9faf32 ("leds: add aw2013 driver") > > Signed-off-by: Tobias Jordan > > This failed to apply to my -for-next tree. Yes, it turns out this had been fixed by Marek already one day before I submitted my patch (in commit 2c6775625434) and I didn't notice that. So nothing to do there, sorry for the inconvenience. Best regards, Tobias