Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp7676pxk; Wed, 30 Sep 2020 16:07:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6HHprNlwNOMixaMquUqvY+YybIrKi4c70VRA0Jnj98+m0B9tyK/hXO1jzrod6CDMgn9FI X-Received: by 2002:aa7:da42:: with SMTP id w2mr5189263eds.287.1601507247211; Wed, 30 Sep 2020 16:07:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601507247; cv=none; d=google.com; s=arc-20160816; b=Wf0ldaAdzM9NxwKhxnD4JamF+OMLlZrIcsywJhKPkSM+MFEkpg+ichitg/KGQK99vH SwepjENy5Yfr1yZYV+8mf2GrUXJ+efa9EXmVhPXbHslaFP8dTk5zIvevAm/RmpZGmyCw s21+/QlzM4/erwXoB21Qf0kkJ5+aJ3ltIzpdHrtN8XWq0OlumBHEau7Q+nZl/k8/QLMO kDn3jb5liOGZm6PcRBC+t4dZxFIdD8n7VnGczivY22XdG80wUWz0sQRK41F32XrUdHn9 l85yH4d1hg3SXMRsjTtyzugIKtmcdd6gZjAKJtVMsEEIU61YKH7S9AuK7ifoO/LlTO4I Sp8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=9VzTsLzEFFALDJWIaO7r/uMpKh3+5xGAabh/w/xISPk=; b=yexdzV8qSb0EJE5hqQrqhaumPF0hEh3QNfm5Rq6AoP4yUd+0nQhz6HeGjw3a8wJsVi MzMYhX22zDWrUZJigcUnccwp+nBQqEbkTXkbPtW/Rr2BheO1UN56Ncj3cnzX5Nfx9VoY +HBV5TGcCl/iq+Vxk/x0nCYqbzIBj8rX6KYRByoGUtYP1ZjynYZzVxeYDEMYSvcbrmTo nkPb1Df+T1l5vj7X7taXqPbAbaqfZtIo+XekEAu1rMn8BdgzKwNNaQN7VoIVogWSfS/I WbbsZ9nzZ+/xVkC+a+FN6++Y2EERxz9bmFX2+kfUGeh9KKisXa9w11JtK4mfLwE2cbSN iDPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d5si2196770ejz.709.2020.09.30.16.07.04; Wed, 30 Sep 2020 16:07:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731043AbgI3WDw (ORCPT + 99 others); Wed, 30 Sep 2020 18:03:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730090AbgI3WDv (ORCPT ); Wed, 30 Sep 2020 18:03:51 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0643C061755; Wed, 30 Sep 2020 15:03:51 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6689213C732A9; Wed, 30 Sep 2020 14:47:02 -0700 (PDT) Date: Wed, 30 Sep 2020 15:03:49 -0700 (PDT) Message-Id: <20200930.150349.1490001851325231827.davem@davemloft.net> To: calvin.johnson@oss.nxp.com Cc: grant.likely@arm.com, rafael@kernel.org, jeremy.linton@arm.com, andrew@lunn.ch, andy.shevchenko@gmail.com, f.fainelli@gmail.com, linux@armlinux.org.uk, cristian.sovaiala@nxp.com, florinlaurentiu.chiculita@nxp.com, ioana.ciornei@nxp.com, madalin.bucur@oss.nxp.com, heikki.krogerus@linux.intel.com, linux-kernel@vger.kernel.org, linux.cj@gmail.com, netdev@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, diana.craciun@nxp.com, laurentiu.tudor@nxp.com, hkallweit1@gmail.com, kuba@kernel.org Subject: Re: [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions From: David Miller In-Reply-To: <20200930160430.7908-3-calvin.johnson@oss.nxp.com> References: <20200930160430.7908-1-calvin.johnson@oss.nxp.com> <20200930160430.7908-3-calvin.johnson@oss.nxp.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 30 Sep 2020 14:47:03 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Calvin Johnson Date: Wed, 30 Sep 2020 21:34:25 +0530 > +struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode) > +{ > + struct device *d; > + struct mdio_device *mdiodev; Please use reverse christmas tree ordering for local variables.