Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp7693pxk; Wed, 30 Sep 2020 16:07:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyr1PmPgULw4a8JdhfeJk9Te7N0/CwWvEJpU9DiUOG3kvjLAmuKuT4GNUu2C9CVVZL1OhVJ X-Received: by 2002:a50:ce4e:: with SMTP id k14mr5191370edj.177.1601507249247; Wed, 30 Sep 2020 16:07:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601507249; cv=none; d=google.com; s=arc-20160816; b=hdXKb4DiYRbUyjhFgDOeFzBbEaJEn9s95Enf1JHs5ugXy/HMHDRg2J2HR5zfw0Dnmp QxDWACCCxzImqqAh4yLMpedMySGqoe8IjiIz91d//Aet3qoPgVwQmNAiFi9UDR+a2nfk UWdrMBRnnTyNojg81eHjmWSl1ai1PhsZ+Rj7WJfCP9Rw7LbhYG9jN/XaJSIXQ+UxfZWl /lG5wHsA7S5lcr31Gfr9qT4Wu2sBAU72OipJkxj9tgRptHEIu0kwUyKtQ9RtNGg+X8+g kh63QmVBpGSi83sYgQoJvE/dVqJ9Z1L2FLtqWS6UMG5/66gICtl2VIdaFb4Pc1ZoYLfq rsWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=NhPMoUqtO8M0GsKKqg+8h/Tam+V9VGbVU4r/mbcwHdM=; b=fxVHV5+noCdoArWb2D+AkjF7SCmltQ0VrbGMA8qIxD2NTQUcapx7XKP4tu2elpzLPp e4mHUSTvTF+eyGPYrGHRpmvd6bPJuHcq+9DIh1v8evnh/JBTi8dbU4mFPcI5VTj2f0zQ m06Z7yiokQ6+TcdX4ih3LAEFTeWTGmv+7Y0gPCghQFhQP3T0TxzrILqbbaHxjrLlb7zw C1Jm1dQ7yPxnzxSIJul9C9Mb+6AqCsoYSOKYTgaHwH4jCzdJrQ5LuOFOKK47Xq7TLhi2 Cvb42pwi8TudfA7I39H8Vsg18bIZ5id4M7oXvs5uIrQrgCX2xVx+AeNZMPy2Lk4obbSk dTtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e2si2152549edu.7.2020.09.30.16.07.07; Wed, 30 Sep 2020 16:07:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731139AbgI3WEU (ORCPT + 99 others); Wed, 30 Sep 2020 18:04:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729912AbgI3WEU (ORCPT ); Wed, 30 Sep 2020 18:04:20 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193B6C061755; Wed, 30 Sep 2020 15:04:20 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 91B6113C732AF; Wed, 30 Sep 2020 14:47:31 -0700 (PDT) Date: Wed, 30 Sep 2020 15:04:18 -0700 (PDT) Message-Id: <20200930.150418.1891146291368222087.davem@davemloft.net> To: calvin.johnson@oss.nxp.com Cc: grant.likely@arm.com, rafael@kernel.org, jeremy.linton@arm.com, andrew@lunn.ch, andy.shevchenko@gmail.com, f.fainelli@gmail.com, linux@armlinux.org.uk, cristian.sovaiala@nxp.com, florinlaurentiu.chiculita@nxp.com, ioana.ciornei@nxp.com, madalin.bucur@oss.nxp.com, heikki.krogerus@linux.intel.com, linux-kernel@vger.kernel.org, linux.cj@gmail.com, netdev@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, diana.craciun@nxp.com, laurentiu.tudor@nxp.com, hkallweit1@gmail.com, kuba@kernel.org Subject: Re: [net-next PATCH v1 4/7] net: mdiobus: Introduce fwnode_mdiobus_register_phy() From: David Miller In-Reply-To: <20200930160430.7908-5-calvin.johnson@oss.nxp.com> References: <20200930160430.7908-1-calvin.johnson@oss.nxp.com> <20200930160430.7908-5-calvin.johnson@oss.nxp.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 30 Sep 2020 14:47:32 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Calvin Johnson Date: Wed, 30 Sep 2020 21:34:27 +0530 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -106,6 +106,46 @@ int mdiobus_unregister_device(struct mdio_device *mdiodev) > } > EXPORT_SYMBOL(mdiobus_unregister_device); > > +int fwnode_mdiobus_register_phy(struct mii_bus *bus, > + struct fwnode_handle *child, u32 addr) > +{ > + struct phy_device *phy; > + bool is_c45; > + const char *cp; > + u32 phy_id; > + int rc; Reverse christmas tree here please.