Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.60.83 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01;
Date:   Wed, 30 Sep 2020 15:40:08 -0700 (PDT)
From:   Stefano Stabellini <stefano.stabellini@xilinx.com>
To:     Rob Herring <robh@kernel.org>
cc:     Ben Levinsky <ben.levinsky@xilinx.com>, stefanos@xilinx.com,
        michals@xilinx.com, michael.auchter@ni.com,
        devicetree@vger.kernel.org, mathieu.poirier@linaro.org,
        emooring@xilinx.com, linux-remoteproc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Jason Wu <j.wu@xilinx.com>, Wendy Liang <jliang@xilinx.com>,
        Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH v16 4/5] dt-bindings: remoteproc: Add documentation for
 ZynqMP R5 rproc bindings
In-Reply-To: <20200929183601.GA892636@bogus>
Message-ID: <alpine.DEB.2.21.2009301536490.10908@sstabellini-ThinkPad-T480s>
References: <20200922223930.4710-1-ben.levinsky@xilinx.com> <20200922223930.4710-5-ben.levinsky@xilinx.com> <20200929183601.GA892636@bogus>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2020 22:40:17.0476
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c715a1a-9582-435d-4266-08d86591cdd0
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT029.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6081
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 29 Sep 2020, Rob Herring wrote:
> > index 000000000000..ce02e425692e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml
> > @@ -0,0 +1,120 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Xilinx R5 remote processor controller bindings
> > +
> > +description:
> > +  This document defines the binding for the remoteproc component that loads and
> > +  boots firmwares on the Xilinx Zynqmp and Versal family chipset.
> > +
> > +  Note that the Linux has global addressing view of the R5-related memory (TCM)
> > +  so the absolute address ranges are provided in TCM reg's.
> 
> blank line needed.
> 
> TCMs specifically I'm concerned about how they are represented in system 
> DT and here...

So far I have been keeping the TCMs in system DT as regular nodes under
/amba. E.g.:

		tcm: tcm@ffe00000 {
			compatible = "mmio-sram";
			reg = <0x0 0xffe00000 0x0 0x10000>;
		};

(I am not sure if "mmio-sram" is the right compatible.)