Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp66982pxk; Wed, 30 Sep 2020 18:07:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMGBVzHR6PNv2+RFSF5/Q3dhc5d2PdUKPAhjl0o8yLMkJE0/e5OZtVPyO8oDZG/SuRKkxn X-Received: by 2002:aa7:da89:: with SMTP id q9mr5587887eds.111.1601514457145; Wed, 30 Sep 2020 18:07:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601514457; cv=none; d=google.com; s=arc-20160816; b=TtCE5YB7tlfa5f/1ufXcDqgq2DoxdkP/CvAOL0xYqfzvo02xzAVMe7Znw7KmbSz6OF gPZIRG1lIq9CYq4n1KAO5KMHfakFGdDyL0BJXJBHED8EOviKORIa1d/mr4a6J+zAB3JK oIEUaacQHei0sTe6lNdNuCzIwuc+jmpy5yLuGD28xobOoLxDC9F32lYoDpmLsu60g9Pp fDWJQ2Homdv4Tm0S3xDDg4YBRXDbF2FOBqEbWtCmDMqj6fWOwo5xsyIV1xSH0Uz4dFIE QhCuQCuQcmLupwIMqNO8qus1qkwiWa0WtZc1G+YX2CxhgoMpZq/JFZrk4AKmKCB8wLc3 J3Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kREN/bOevCqCefEiqcu5963AVtvCoPNDNjWTDSgQ4bk=; b=qwKClOhl4JhtxHNoYITRciJoSc6oKrKmQTKRhQQk8PRMDjyaMCNbmgEoXs2oLNy+ZK weZVYScuXFpB4h4UP0joa5iwtKtSk4e0LT2/31EI2IJitKD0uxPKPvbZD8MIVdHwx6Gk Y4dkcQMC1yPBN7EH9+nmHeElS11p9+o1s9QWOxQaN3DNxFGT4XxtTXrcPa4HY6aDh8T8 QQ9erPYbKKStkdPKz6DDjy49iy2Or/lC3HLnALe/agr7s1xtmouxbaXhaKFLKxw4IhyS Wt1zaHLXpJgzP7FS7GbTo+ZEQVJc2+LNVP4qHYRlYURSNQDQq7ThfZ3uLEYJ+2XFPR+h x1Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WEHLJvOR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k16si2253037edv.269.2020.09.30.18.07.14; Wed, 30 Sep 2020 18:07:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WEHLJvOR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731566AbgI3XX7 (ORCPT + 99 others); Wed, 30 Sep 2020 19:23:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730398AbgI3XX5 (ORCPT ); Wed, 30 Sep 2020 19:23:57 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1DEFC0613D0 for ; Wed, 30 Sep 2020 16:23:57 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id w7so2537278pfi.4 for ; Wed, 30 Sep 2020 16:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kREN/bOevCqCefEiqcu5963AVtvCoPNDNjWTDSgQ4bk=; b=WEHLJvORopfW9SqVzjuIBplovl593zKzDltPW/iKhjkazT8C9tkdavbcR6JpyM1PkY uyLweiQZF3Vc/EeISGMjIdoz2rHu7kBTj0eX2kBjstC+iuwEwBg+doSVlBTw+nkCqnaE YAOl/QveetXkwgDn12/InOw/fdsLMGwWt1otE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kREN/bOevCqCefEiqcu5963AVtvCoPNDNjWTDSgQ4bk=; b=ZwavMVALkntvbInk4iNrQhFQKV4GynPl8TCLmCoby2AE65jjI77ReFWEnV+bWhH3Iu zoludWOgKcFc+zJ2oeWWvU4SqtMLKdwNgVpO948n8heAGCCe41zckkjNnWxEF51nFd0B zGZNOIHC0mboRh5dvG4eMnCX3G5OU+IkR5MhbMYylfeXEYc9+CxdyCiz79/t71jaFhdx GO4MHNnYsSU+a/jZ31XQnHlmmbD3+ICbd2efTQ2Oxa34N5EDOPucmPkhuqvo6BHTszzX m8W+GtlJeVqQTU7GNQJZf0s++hnw8KF6F8tUwFWxKK7CBKd93x2S3Ep5cUwYmEk59KPU NAuw== X-Gm-Message-State: AOAM530iMu+FJ72UqPG8KJMIHTaAkp3rhdHOW4MagsAA8qzUXXtQvObh K8rzYw4cPi4YXsYHT0LgF42k8w== X-Received: by 2002:a63:591e:: with SMTP id n30mr3969654pgb.340.1601508237388; Wed, 30 Sep 2020 16:23:57 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id fz22sm3260765pjb.46.2020.09.30.16.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 16:23:56 -0700 (PDT) Date: Wed, 30 Sep 2020 16:23:55 -0700 From: Kees Cook To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , Jonathan Corbet , Anton Vorontsov , Colin Cross , Tony Luck , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 34/52] docs: pstore-blk.rst: fix kernel-doc tags Message-ID: <202009301623.496E3F85@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2020 at 03:24:57PM +0200, Mauro Carvalho Chehab wrote: > There is currently a problem with kernel-doc tags from blk.c: > > .../Documentation/admin-guide/pstore-blk:239: ./fs/pstore/blk.c:175: WARNING: Duplicate C declaration, also defined in 'admin-guide/pstore-blk'. > Declaration is 'register_pstore_device'. > .../Documentation/admin-guide/pstore-blk:239: ./fs/pstore/blk.c:432: WARNING: Duplicate C declaration, also defined in 'admin-guide/pstore-blk'. > Declaration is 'register_pstore_blk'. > .../Documentation/admin-guide/pstore-blk:242: ./include/linux/pstore_blk.h:43: WARNING: Duplicate C declaration, also defined in 'admin-guide/pstore-blk'. > Declaration is 'pstore_device_info'. > > Basically, the internal parts is shown with :export:, instead > of :internal:. Yet, there are some other exported docs that > aren't at the document, because they lack :identifiers:. > > So, instead, let's just use :export: at the kAPI part of > the documentation. > > Signed-off-by: Mauro Carvalho Chehab That should work; thanks! Acked-by: Kees Cook -- Kees Cook