Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next] net: dsa: Support bridge 802.1Q while untagging
From:   Florian Fainelli <f.fainelli@gmail.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20200930203103.225677-1-f.fainelli@gmail.com>
 <20200930204358.574xxijrrciiwh6h@skbuf>
 <89404248-f8ea-b5f5-12c5-a19392397222@gmail.com>
Message-ID: <30265d9b-fb50-16a7-fb08-1199762a14b3@gmail.com>
Date:   Wed, 30 Sep 2020 17:16:56 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <89404248-f8ea-b5f5-12c5-a19392397222@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 9/30/2020 4:29 PM, Florian Fainelli wrote:
> 
> 
> On 9/30/2020 1:43 PM, Vladimir Oltean wrote:
>> On Wed, Sep 30, 2020 at 01:31:03PM -0700, Florian Fainelli wrote:
>>> While we are it, call __vlan_find_dev_deep_rcu() which makes use the
>>> VLAN group array which is faster.
>>
>> Not just "while at it", but I do wonder whether it isn't, in fact,
>> called "deep" for a reason:
>>
>>         /*
>>          * Lower devices of master uppers (bonding, team) do not have
>>          * grp assigned to themselves. Grp is assigned to upper device
>>          * instead.
>>          */
>>
>> I haven't tested this, but I wonder if you could actually call
>> __vlan_find_dev_deep_rcu() on the switch port interface and it would
>> cover both this and the bridge having an 8021q upper automatically?
> 
> Let me give this a try.

We hit the if (vlan_info) branch and we do not recurse through the 
upper_dev because of that.

I still need to send a v2 to remove the now unused 'iter' variable and 
fix up the bridge iproute2 command (there is no vlan_filtering=0 it is 
vlan_filtering 0).
-- 
Florian