Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        b.zolnierkie@samsung.com, m.szyprowski@samsung.com
Subject: Re: [PATCH] ARM: dts: exynos: Add a placeholder for a MAC address
Date:   Thu, 01 Oct 2020 10:36:14 +0200
In-Reply-To: <20201001072236.GA4815@kozik-lap> (Krzysztof Kozlowski's
        message of "Thu, 1 Oct 2020 09:22:36 +0200")
Message-ID: <dleftjr1qigx6p.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20201001072236.GA4815@kozik-lap>
        <CGME20201001083615eucas1p2886f47d032844823b419a92fa02994ad@eucas1p2.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-10-01 czw 09:22>, when Krzysztof Kozlowski wrote:
> On Wed, Sep 30, 2020 at 04:31:51PM +0200, =C5=81ukasz Stelmach wrote:
>> Add a placeholder for a MAC address. A bootloader may fill it
>> to set the MAC address and override EEPROM settings.
>>=20
>> Signed-off-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>=20
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/=
dts/exynos5422-odroidxu3.dts
>> index db0bc17a667b..9f7f3eacb750 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -70,3 +70,21 @@ &pwm {
>>  &usbdrd_dwc3_1 {
>>  	dr_mode =3D "peripheral";
>>  };
>> +
>> +&usbhost2 {
>> +	#address-cells =3D <1>;
>> +	#size-cells =3D <0>;
>> +
>> +	hub@1 {
>> +		compatible =3D "usb8087,0024";
>> +		reg =3D <1>;
>> +		#address-cells =3D <1>;
>> +		#size-cells =3D <0>;
>> +
>> +		ethernet: usbether@1 {
>> +			compatible =3D "usb0c45,6310";
>> +			reg =3D <1>;
>> +			mac-address =3D [00 00 00 00 00 00]; /* Filled in by a bootloader */
>
> Why do you need a placeholder? U-Boot can just append the
> address/property.

Several other dts files have such placeholder

git grep 'mac-addr.*\[00 00 00 00 00 00\]' arch/arm/boot/dts/ | wc -l
26

I can see two scenarios where this patch may be helpful. Another
(simple) boot loading code might be used. The value may also be
customized during build time and used without any support of a
bootloader.

Finding and filling a placeholder would be easier in u-boot too.

And it serves as a reference how to configure a USB device in a dts
file.

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl91lP4ACgkQsK4enJil
gBC7CQf8Daar9/v03mcyngKOdjq/OdNBbF8xnkL8pJ4B4VmhjtmdszYH+P9+p4KI
GZAMGardhItVjNrHJlkxHXly7z3eqy/lwSgU2BnXOshpSEGmG0cIYPKs3hjBBzzD
gIxOlVvgBoKJnQe/RSOSX+Exra8VaS+5Xtcv+fQq3XHWAEUm14VY8IbqICuGUeNS
FyIhvfHjxUKCwvO0NMWJaSIp6XjECchhHi8gwhJ8bvEV9xzm3EgOAuhfaHGw3BxW
9hdVqVuLr6Yl+hm2+rf35q/qmMVpGGaBxfH2xFgpIq4kjtEKIHT0rnokUaNbRnZ1
BTFUWia9Fk44U0B/rKB73c3ItaU50Q==
=hQtz
-----END PGP SIGNATURE-----
--=-=-=--