Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201001120717.13027-1-frieder.schrempf@kontron.de>
 <20201001125722.GA6082@kozik-lap> <985c5eb3-3f8a-2b70-8831-b7b52671ee4f@kontron.de>
 <6f2b294f-9f28-fe1b-bd1a-d32cbdb86e00@kontron.de>
In-Reply-To: <6f2b294f-9f28-fe1b-bd1a-d32cbdb86e00@kontron.de>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Thu, 1 Oct 2020 16:25:14 +0200
Message-ID: <CAJKOXPePy2-CS1YuEWTksFjR5wP=HWtEixRR3wwsCSK59ckX2w@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards
To:     Frieder Schrempf <frieder.schrempf@kontron.de>
Cc:     Andreas Kemnade <andreas@kemnade.info>,
        Anson Huang <Anson.Huang@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Li Yang <leoyang.li@nxp.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Marco Felsch <m.felsch@pengutronix.de>,
        Michael Walle <michael@walle.cc>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Robert Jones <rjones@gateworks.com>,
        Rob Herring <robh@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        =?UTF-8?Q?S=C3=A9bastien_Szymanski?= 
        <sebastien.szymanski@armadeus.com>,
        Shawn Guo <shawnguo@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 1 Oct 2020 at 16:24, Frieder Schrempf
<frieder.schrempf@kontron.de> wrote:
>
> On 01.10.20 15:30, Frieder Schrempf wrote:
> > On 01.10.20 14:57, Krzysztof Kozlowski wrote:
> >> On Thu, Oct 01, 2020 at 02:06:58PM +0200, Schrempf Frieder wrote:
> >>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>>
> >>> Kontron Electronics GmbH offers small and powerful SoMs based on the
> >>> i.MX8M Mini SoC including PMIC, LPDDR4-RAM, eMMC and SPI NOR.
> >>>
> >>> The matching baseboards have the same form factor and similar interfaces
> >>> as the other boards from the Kontron "Board-Line" family, including
> >>> SD card, 1G Ethernet, 100M Ethernet, USB Host/OTG, digital IOs, RS232,
> >>> RS485, CAN, LVDS or HDMI, RTC and much more.
> >>>
> >>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>> ---
> >>> Changes for v3:
> >>> * Remove needless status properties
> >>> * Remove needless regulator properties for reg_vdd_5v
> >>> * Use proper PHY reset properties in PHY node
> >>> * Use phy-connection-type instead of phy-mode
> >>> * Adjust PMIC node name and label
> >>> * Add over-current-active-low to usbotg1 node
> >>> * Remove redundant bus-width property from usdhc2 node
> >>> * Remove needless regulator-compatible from reg_vdd_snvs
> >>> * Set minimum voltage to 85mV for reg_vdd_snvs
> >>>
> >>> Changes for v2:
> >>> * Make the licensing less strict (GPL-2.0+ OR MIT)
> >>> * Merge the SoM and baseboard DTs for N8010 and N8011 into one as
> >>>    they only differ in DDR and eMMC size.
> >>> * Change compatibles and model strings to "n810x" and "N8010X".
> >>> * Only use a common memory node that will be updated by the
> >>>    bootloader reflecting the detected DDR size.
> >>> * Improve naming for 16MHz CAN fixed oscillator and set
> >>>    "clock-output-names".
> >>> * Consistently use "reg_" prefix for regulators.
> >>> * Remove "userspi" node.
> >>> * Slightly improve commit message.
> >>> ---
> >>>   .../dts/freescale/imx8mm-kontron-n801x-s.dts  | 323 ++++++++++++++++++
> >>>   .../freescale/imx8mm-kontron-n801x-som.dtsi   | 293 ++++++++++++++++
> >>>   2 files changed, 616 insertions(+)
> >>>   create mode 100644
> [...]
> >>
> >>> +
> >>> +        regulators {
> >>> +            reg_vdd_soc: BUCK1 {
> >>> +                regulator-name = "BUCK1";
> >>
> >> All regulator names should be lowercase, as dtschema asks. Node names
> >> can stay uppercase, although I guess it would be better to have them
> >> lower as it is also naming convention for device tree.
> >
> > Ok, I will change the regulator and node names to lowercase.
>
> I just found out that the pca9450 driver actually uses the upper case
> node names for matching. So I will keep the upper case node names for
> now and only change the regulator names.
>
> Afterwards we can fix the node names in the driver and in the DTs in a
> separate patch if required.

Right, I forgot that it's important for the driver. Thanks for checking it.

Best regards,
Krzysztof