Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp557503pxk; Thu, 1 Oct 2020 08:51:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeb94xWJloCZE1wmOAKV7rVNcIMXi/++wm9KJFQJcCqJnSZa5BCszSmoif+WTOIEPEGOGR X-Received: by 2002:a17:906:9511:: with SMTP id u17mr8371830ejx.194.1601567474655; Thu, 01 Oct 2020 08:51:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601567474; cv=none; d=google.com; s=arc-20160816; b=Z2A9m/+ZNysBIbkEZ5UQuVdkjHkDeM/9kutpt118cOmDnBJi4eakzbInoYwiE260HM fFtY8Wi6ur880Oifd7kFuRGh98BiulGe3MFgAlIyVQXP/a0rfRmmS2GrVZ3wlSeiaVay imwFDd35q2S5iCGZTB/l6DhV1N6GmBT2VuNVZ9ATTC1a8UZSLnHEpeu3tnbgFCfNqkEL I11sE7w48IJBjIC3NX3eYc6iBVfsInQaSwjMLHE8wRkTohLJHsYvEIdv8FZfk7q0VNZz 4iEnp6Wyx95Enc/XD0kvPUnr9f94BoYXfaOchD3RHfWikr5lvajPWyjVb740AjHt/0Bw 3EIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oiTRa+VL3UYBQkggS5s/6LNHr5dPZxoNb4+G/XwOhxk=; b=IvoIvh5ipquNiOkJjApC3uyeBX6TI/1yLwHMZ3wv/LkDfHv/pnbjU/uRQv2uF7OhpU ++i8WJZz6NrWCletkvR0JqstmRjHwHn6/Uyk25bEO1GN6HBpXIgYZrAVhzdXtp4UYByl 92Odb2Jwh6gwutSfVtDr3cch6/0qFBxMxWuOWBDzPdTZkf/eRLddoN3STj9BN+1kXUM8 ZFh5XvRcJz3xluJbZTEq+ObgaUmvQ8HrBYR9OUeJtFRQMfLLodPJxlncz7AgtfHdDVH2 pKc4N6uGwkEGwO1/8wkH3WWohwZZuDjVy0gndFGjX5YKFK1HBscCfrVIKykrOvBkaplO McVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KpHip++u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn22si3760776edb.231.2020.10.01.08.50.43; Thu, 01 Oct 2020 08:51:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KpHip++u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732607AbgJAPtg (ORCPT + 99 others); Thu, 1 Oct 2020 11:49:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59284 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732507AbgJAPtg (ORCPT ); Thu, 1 Oct 2020 11:49:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601567375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oiTRa+VL3UYBQkggS5s/6LNHr5dPZxoNb4+G/XwOhxk=; b=KpHip++un7Gd1DCLvPdPjvQ6kk038l9RqrC1XB4VT7ea75MfYPK0jHuWW1mBbecZd+Y4hQ qVCzgb+y7yjS5Usa7KaEnGSDlI7+0W25gewl0VCU8ZW6JCRV71JqR1UjSJom5eIgVUVNaN bK6+1q0MSfbKISaTCZtYyJ/MEg9+fxk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-V-0SDF6zNCGHF2bdrKJvuQ-1; Thu, 01 Oct 2020 11:49:01 -0400 X-MC-Unique: V-0SDF6zNCGHF2bdrKJvuQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CCC97805EE3; Thu, 1 Oct 2020 15:48:58 +0000 (UTC) Received: from localhost (ovpn-12-47.pek2.redhat.com [10.72.12.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B7B919650; Thu, 1 Oct 2020 15:48:47 +0000 (UTC) From: Ming Lei To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Cc: Ming Lei , Veronika Kabatova , Sagi Grimberg , Tejun Heo , Christoph Hellwig , Jens Axboe , Bart Van Assche Subject: [PATCH V7 0/2] percpu_ref & block: reduce memory footprint of percpu_ref in fast path Date: Thu, 1 Oct 2020 23:48:40 +0800 Message-Id: <20201001154842.26896-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, The 1st patch removes memory footprint of percpu_ref in fast path from 7 words to 2 words, since it is often used in fast path and embedded in user struct. The 2nd patch moves .q_usage_counter to 1st cacheline of 'request_queue'. Simple test on null_blk shows ~2% IOPS boost on one 16cores(two threads per core) machine, dual socket/numa. V7: - add comments about reason for struct split V6: - drop the 1st patch which adds percpu_ref_is_initialized() for MD only, since Christoph doesn't like it V5: - fix memory leak on ref->data, only percpu_ref_exit() of patch 2 is modified. V4: - rename percpu_ref_inited as percpu_ref_is_initialized V3: - fix kernel oops on MD - add patch for avoiding to use percpu-refcount internal from md code - pass Red Hat CKI test which is done by Veronika Kabatova V2: - pass 'gfp' to kzalloc() for fixing block/027 failure reported by kernel test robot - protect percpu_ref_is_zero() with destroying percpu-refcount by spin lock Ming Lei (2): percpu_ref: reduce memory footprint of percpu_ref in fast path block: move 'q_usage_counter' into front of 'request_queue' drivers/infiniband/sw/rdmavt/mr.c | 2 +- include/linux/blkdev.h | 3 +- include/linux/percpu-refcount.h | 52 ++++++------ lib/percpu-refcount.c | 131 ++++++++++++++++++++++-------- 4 files changed, 125 insertions(+), 63 deletions(-) Cc: Veronika Kabatova Cc: Sagi Grimberg Cc: Tejun Heo Cc: Christoph Hellwig Cc: Jens Axboe Cc: Bart Van Assche -- 2.25.2