Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/3] nvmem: qfprom: Don't touch certain fuses
To:     Evan Green <evgreen@chromium.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Douglas Anderson <dianders@chromium.org>,
        Stephen Boyd <swboyd@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20200929205807.2360405-1-evgreen@chromium.org>
 <20200929135741.3.I1bb1b0e94be3b792804e08831d6a55481e162d63@changeid>
 <8f467220-3ac8-c8fc-33fe-8d86904571fe@linaro.org>
 <CAE=gft5FoWpscS_9CfuCNSZxsq_CUu_AShQ=tLiW=NGL8YG5tQ@mail.gmail.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <d79de840-25cc-0e8e-15e6-3cc2fda2e38b@linaro.org>
Date:   Thu, 1 Oct 2020 17:30:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <CAE=gft5FoWpscS_9CfuCNSZxsq_CUu_AShQ=tLiW=NGL8YG5tQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 01/10/2020 17:27, Evan Green wrote:
> On Thu, Oct 1, 2020 at 7:17 AM Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
>>
>> Hi Evan,
>>
>> On 29/09/2020 21:58, Evan Green wrote:
>>> Some fuse ranges are protected by the XPU such that the AP cannot
>>> access them. Attempting to do so causes an SError. Use the newly
>>> introduced per-soc compatible string to attach the set of regions
>>> we should not access. Then tiptoe around those regions.
>>>
>>
>> This is a generic feature that can be used by any nvmem provider, can
>> you move this logic to nvmem core instead of having it in qfprom!
> 
> Sure! I'd prefer to keep this data in the driver for now rather than
Ofcourse these can come from driver directly based on compatible!

> trying to define DT bindings for the keepout zones. So then I'll pass
> in my keepout array via struct nvmem_config at registration time, and
> then the core can handle the keepout logic instead of qfprom.c.
> 

Yes, that is inline with what am thinking of as well!


00srini
> -Evan
>