Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp819751pxk; Thu, 1 Oct 2020 14:52:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUPntrIcxZEGy3GSIgcDk5c3GdGuuYB7fhGxAOQV1HIFcNUqFnFj2al8Ko6yXXs3Da07LS X-Received: by 2002:a05:6402:699:: with SMTP id f25mr5327252edy.372.1601589153493; Thu, 01 Oct 2020 14:52:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601589153; cv=none; d=google.com; s=arc-20160816; b=nJ3UDLGctGavQpQPVwuS1cyQEsZKqlyZ1zM3XMOS9lfzxjeyo8GL1hYNVETrnTZF8c zamvQhZa4P8p2PIFzgUNMrr+PjSQkd8VjC5/Fs8ARYIIYpuGG6RRKj5MCWS5QYq9bpkH OQAGIjoFeXQz6ZXDMg5h+hEN51tDOhkkYLTGNP1aQrLa8JCsFuJtVDgh/Ni4uXUgkHHt pVib8K3yUG8TrgeIqjjDTANp3m+3quIv18cNfOmhYpeZn+lTF3mlC/HqTpoAVro+wQKj QOH9Fs0b5kowQorUV+HegInuJN8QCrMmz6nFGUO3y1UQjAnWXesPeSnrfug/xpNNGqAo u+dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=1i7uL5AC4DA4mzdI6uqQhmn+EbFGsDSVrWEaMTablIU=; b=x1mS8KkC4qy+xAI2y6GI/ndrzurJD/nZV9u6ysFn4apnKKl5pOjK3EFsfuoEpCiV6D NZZXo3JFyn3tN+gZClLWFgYULubiEKaRhKVO90DTn84F6ut1k2FDhuPJpfRF3gehZpXv BMXCybk4SGs/kRNt+UyQ3aYcKNu7olMyKX7gYFwVxKZyWT9mFDaGr6hPK5esujkiwgi8 A8wEuP1+sjXX/vqtaOMTRDneuVL9ehYSPSUsPL3w1+JOAVJYxeSog5BABBNpI1rGyPDF Ejypqc+w2EAQH28M1J9Mm2iytWHAPlvJ3bxkWFis6XxMPKgpNmDT9bQq/R/CM6oDvQ+d QVBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qo18si1457930ejb.161.2020.10.01.14.52.11; Thu, 01 Oct 2020 14:52:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733143AbgJAVuk (ORCPT + 99 others); Thu, 1 Oct 2020 17:50:40 -0400 Received: from mga01.intel.com ([192.55.52.88]:20207 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727017AbgJAVuk (ORCPT ); Thu, 1 Oct 2020 17:50:40 -0400 IronPort-SDR: 0N7yM66fRGXCEDQW6R1L2ii8qTIRPLX5wgmzTyL4uXDM8k02uvosR01X9bd9fgEot47S2g7iNR ls/JdVa1vdiw== X-IronPort-AV: E=McAfee;i="6000,8403,9761"; a="180994235" X-IronPort-AV: E=Sophos;i="5.77,325,1596524400"; d="scan'208";a="180994235" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2020 14:50:39 -0700 IronPort-SDR: XUrwvxFOeLSMRXlDoaClCE5+M8+66alqfK4DH+gAj9iHdvIHGkHRVG0W/0YE16qMC8d8GpDi8Z Kp9qT0ElOZvw== X-IronPort-AV: E=Sophos;i="5.77,325,1596524400"; d="scan'208";a="505733140" Received: from kignaci-mobl1.amr.corp.intel.com (HELO [10.251.133.95]) ([10.251.133.95]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2020 14:50:38 -0700 Subject: Re: How should we handle illegal task FPU state? To: Sean Christopherson , "Yu, Yu-cheng" Cc: Andy Lutomirski , LKML , X86 ML , Rik van Riel , Andrew Cooper References: <71682bce-a925-d3bd-18ef-d2e4eb8ebc8e@intel.com> <20201001205857.GH7474@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Thu, 1 Oct 2020 14:50:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201001205857.GH7474@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/1/20 1:58 PM, Sean Christopherson wrote: > One thought for a lowish effort approach to pave the way for CET would be to > try XRSTORS multiple times in switch_fpu_return(). If the first try fails, > then WARN, init non-supervisor state and try a second time, and if _that_ fails > then kill the task. I.e. do the minimum effort to play nice with bad FPU > state, but don't let anything "accidentally" turn off CET. I'm not sure we should ever keep running userspace after an XRSTOR* failure. For MPX, this might have provided a nice, additional vector for an attacker to turn off MPX. Same for pkeys if we didn't correctly differentiate between the hardware init state versus the "software init" state that we keep in init_task. What's the advantage of letting userspace keep running after we init its state? That it _might_ be able to recover?