Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 11/15] misc: bcm-vk: add BCM_VK_QSTATS
To:     Scott Branden <scott.branden@broadcom.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Olof Johansson <olof@lixom.net>
Cc:     Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        Desmond Yan <desmond.yan@broadcom.com>
References: <20201001012810.4172-1-scott.branden@broadcom.com>
 <20201001012810.4172-12-scott.branden@broadcom.com>
 <e7b3a4b6-0662-6ead-8ddb-0cf6324a9bd2@gmail.com>
 <5d76c89d-f53a-be22-dcd7-7854a3e1e034@broadcom.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <0fb4556e-91bf-d364-c7bb-c876136b3991@gmail.com>
Date:   Thu, 1 Oct 2020 15:13:32 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <5d76c89d-f53a-be22-dcd7-7854a3e1e034@broadcom.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 10/1/2020 3:12 PM, Scott Branden wrote:
> 
> 
> On 2020-09-30 7:33 p.m., Florian Fainelli wrote:
>>
>>
>> On 9/30/2020 6:28 PM, Scott Branden wrote:
>>> Add BCM_VK_QSTATS Kconfig option to allow for enabling debug VK
>>> queue statistics.
>>>
>>> These statistics keep track of max, abs_max, and average for the
>>> messages queues.
>>>
>>> Co-developed-by: Desmond Yan <desmond.yan@broadcom.com>
>>> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>>> ---
>>
>> [snip]
>>
>>> +#if defined(CONFIG_BCM_VK_QSTATS)
>>> +    /* clear qstats */
>>> +    for (i = 0; i < VK_MSGQ_MAX_NR; i++) {
>>> +        memset(&vk->to_v_msg_chan.qstats[i].qcnts, 0,
>>> +               sizeof(vk->to_v_msg_chan.qstats[i].qcnts));
>>> +        memset(&vk->to_h_msg_chan.qstats[i].qcnts, 0,
>>> +               sizeof(vk->to_h_msg_chan.qstats[i].qcnts));
>>> +    }
>>> +#endif
>>>        /* clear 4096 bits of bitmap */
>>>        bitmap_clear(vk->bmap, 0, VK_MSG_ID_BITMAP_SIZE);
>>
>> It was not clear from looking at this patch how are the statistics exposed and how does one actually get them?
> The QSTATS, since it is only for debug purpose, it will dump out periodically based on processed_num.
> Nothing fancy as we only compile it in in extreme case for recreating a scenario.

But what kind of interface is that? Cannot you at least expose those 
through sysfs if nothing else?
-- 
Florian