Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1091880pxk; Fri, 2 Oct 2020 00:16:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkLsg7+gR/mRQVZydX5SkIU41eYoKyp7YqLSzBruOlI9vEjbM0iajKfRcJhBblAyhIdVif X-Received: by 2002:a17:906:6682:: with SMTP id z2mr930418ejo.434.1601623011464; Fri, 02 Oct 2020 00:16:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601623011; cv=none; d=google.com; s=arc-20160816; b=lKADNShSD46MkiEuEiQDRqp0VMNd73MsLqzhK6aTokRCCAbSOQm/R3FORRRz8yepof dtFrFAE0ZQ4o/KEKouL0d/URwsOg9YRKVvB9vqwY6UupxpsuRd8BoUgS2bL9InHKTwuq IDSoPLlb28Ofp2Em4CE2roJKB73in7F9vllvvAhV8r5vsOKjhl9QrBRKoaD7RzF3HQAB 9GEs4OUwxqgCxSKieJBt9z5Mwt0zNKZOISfIP8XwkSTwOiTednKlqeWenYaiU5fErkHy sY0KakxTT9Di8Dx00u3vMNQacnwzhZzmXYqXDTEOzIM6X8ltLTzth4HxaUTyGKIy0ly9 /Ydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=te0P5h4D6Mc9Ry+VG1JF2szLbFueA5KKEqcGsOd/Wvo=; b=a7BCbOqPH0ZRqTiKGY1Y+1E19Q2IW51VvXx3OtUzh8xrmvDWYgwsDv5LDxofT6E0vX eecmNgLzPU8BeoB5zqAebMihq0iv3kbqYBtqL1Zd0M8L32fdhTn92jX79e1NjhkEswKS wEv6grbKqXCmgEUanKTP90MOV1olp7SP2iqNs4aeHrcnTbdKlgJRB9QLiXq1ThaCK4mb M1jfw2ITpUoANed3O90gZ6WcBM2fXTrcUhUlBjtUGPier4N634/zEDNAdSZaZUAscfEK MjOE5gJES+wqxKEfPO+ui3cEGxe6hWdmhSPg1es/Z4rNZSa/vkmM4W7pmwKzLJ/4HI8g 7Xgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j22si488831eds.357.2020.10.02.00.16.29; Fri, 02 Oct 2020 00:16:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726029AbgJBHP0 (ORCPT + 99 others); Fri, 2 Oct 2020 03:15:26 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:38911 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgJBHP0 (ORCPT ); Fri, 2 Oct 2020 03:15:26 -0400 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id EFA5B1BF217; Fri, 2 Oct 2020 07:15:20 +0000 (UTC) From: Miquel Raynal To: Florian Fainelli , linux-mtd@lists.infradead.org Cc: Miquel Raynal , Vignesh Raghavendra , Richard Weinberger , open list , =?utf-8?q?=C3=81lvaro_Fern=C3=A1n?= =?utf-8?q?dez_Rojas?= , Jonas Gorski Subject: Re: [PATCH] mtd: parsers: bcm63xx: Do not make it modular Date: Fri, 2 Oct 2020 09:15:19 +0200 Message-Id: <20201002071519.26282-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200929172726.30469-1-f.fainelli@gmail.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b597cc75f7fe76708bc6ab3f0e09bbff6f09ae4a Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-09-29 at 17:27:21 UTC, Florian Fainelli wrote: > With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE > detection"), we generate a reference to fw_arg3 which is the fourth > firmware/command line argument on MIPS platforms. That symbol is not > exported and would cause a linking failure. > > The parser is typically necessary to boot a BCM63xx-based system anyway > so having it be part of the kernel image makes sense, therefore make it > 'bool' instead of 'tristate'. > > Fixes: 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE detection") > Signed-off-by: Florian Fainelli Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel