Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] selftests/vm: fix: make check_config.sh executable
To:     Stephen Rothwell <sfr@canb.auug.org.au>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Next <linux-next@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
References: <20201002064811.435769-1-jhubbard@nvidia.com>
 <20201002175931.5317ef64@canb.auug.org.au>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <2bd44214-ff9c-0333-9525-3db29b9a3ff1@nvidia.com>
Date:   Fri, 2 Oct 2020 01:10:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201002175931.5317ef64@canb.auug.org.au>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/2/20 12:59 AM, Stephen Rothwell wrote:
> Hi John,
> 
> On Thu, 1 Oct 2020 23:48:11 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
>>
>> commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs
>> dependency") created the new check_config.sh file without the execute
>> bits set. This is a problem because the Makefile runs it with "./", so
>> now "make" is failing in that directory.
>>
>> The posted patch [1] does seem to have it as an executable file, so I'm
>> not sure how this happened. But in any case, make check_config.sh
>> executable again, so that "make" in selftests/vm works once again.
> 
> The correct fix is to make sure that the Makefile runs it explicitly
> with a shell because is such a patch is applied with patch(1), the
> execute bit will not be preserved.
> 
> See e.g. in the top level Makefile:
> 
> 	$(CONFIG_SHELL) $(srctree)/scripts/gen_autoksyms.sh $@
> 

OK...we should also fix it anyway, seeing as how the run_vmtest.sh also needs
the execute bit re-set, yes?

So I guess I should send a patch that does:

* chmod +x on both run_vmtest.sh and check_config.sh, plus

* invoke check_config.sh via $(CONFIG_SHELL) from the Makefile.

Does that sound about right?

thanks,
-- 
John Hubbard
NVIDIA