Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Oct 2020 12:03:50 +0200
From:   Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Roman Gushchin <guro@fb.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shakeel Butt <shakeelb@google.com>,
        Michal Hocko <mhocko@kernel.org>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, kernel-team@fb.com
Subject: Re: [PATCH v4 4/4] mm: convert page kmemcg type to a page memcg flag
Message-ID: <20201002100350.GC24008@blackbody.suse.cz>
References: <20201001002710.748166-1-guro@fb.com>
 <20201001002710.748166-5-guro@fb.com>
 <20201001170036.GA29848@blackbook>
 <20201001172713.GA500308@cmpxchg.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="MnLPg7ZWsaic7Fhd"
Content-Disposition: inline
In-Reply-To: <20201001172713.GA500308@cmpxchg.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--MnLPg7ZWsaic7Fhd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 01, 2020 at 01:27:13PM -0400, Johannes Weiner <hannes@cmpxchg.org> wrote:
> The activation code is the only path where page migration is not
> excluded. Because unlike with page state statistics, we don't really
> mind a race when counting an activation event.
Thanks for the explanation. I see why the accessor trio is justified.

> I do think there is a bug, though: mem_cgroup_move_account() should
> use WRITE_ONCE() on page->mem_cgroup.
If this were a bug, wouldn't be the proper approach
rcu_assign_pointer()/rcu_dereference() pair?

Michal

--MnLPg7ZWsaic7Fhd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEEoQaUCWq8F2Id1tNia1+riC5qSgFAl92+wMACgkQia1+riC5
qSjoXBAAijzh02/9TXGICO7j+GMJCp6nN4wR6sLgCwSepvipg9XWa14yJiDqRzy1
hHVRStm2iKcS3jGsCWsz0qvE+k9CDosua5asddxwfQXWggJszaTzkrTEkBIj/iIW
jFR8sMzmgfHSIo+m93FvRT/QHoZC1s4+J/PauBwvUwCLN0kB6/V964HIbt+m6zKO
xAzczqa6H/JMFPovVu6gGguT8dZqA847COfuD3+J8ZkK3ZUTu74epXEAjJarkokQ
ibkZwuEVOzqoB3CuCugb2dO0W6bqcFXqZw6T4V1FG54QwpoBiq9/kGcG7Z3djIr2
15kRQIbE7JqtLJQMYD+oXbLpKoUUXXZkuhUNWh8ozrX5m4kBeXkIeOpCEZlHqYrH
Mc8ydvwx+Ajy0oofmDqqNKd8aV/9bBAVQpqxsZD/fRjIzkaT20HQnTMtK6UgnsH4
2gw5NCGv0EiCEBhpdWIlwFoaNMOinYeZwr+nPVK4WZLSyZZyPcBFdIW+7O7WkfPK
n39mmmngFevD/EP2iCyC8hhZ6Uht+qVeVHVpHKvE82NgrDfUSuhoKbJBNoYQrIV3
57MLMrP/RACcxU/3D06asMPg08k36b3yV5TuSDcu3E/PlLpZnwlQEblws8+120/k
xKEnW1XoA2zRaOB1ojkNy+YcyBOlmdPFMRjAgKffEc4U6wZbNcw=
=Qjsf
-----END PGP SIGNATURE-----

--MnLPg7ZWsaic7Fhd--