Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1329754pxk; Fri, 2 Oct 2020 07:03:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsInBmRLa5SKfY1htD1rUM7ms3A5US0gVtst9NqekJqPlBRLAFA26Hp1R2tZq16kv//OyJ X-Received: by 2002:a17:906:ad94:: with SMTP id la20mr2381801ejb.522.1601647406335; Fri, 02 Oct 2020 07:03:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601647406; cv=none; d=google.com; s=arc-20160816; b=c/8dqhngEsK1IyrgbcDJUm/qWkmV0TAa3+CVEvZUuCR0HHO3N6hmVeWTg7Fqb3y4As q7JvFMGCbWYwu/VGQUgPzoxIhyJ/SoYENYc83V5DiUBozX70P1reoj+4tIMNXL9+m923 6o+7l51bpyLRYN1EFhBOkqsIGNLZXlugAunfe1Pp5oD9bPEYWhQfK504s1eheoNl36zW H7qLioa93XaQweOq/zhU2mybTIdHmczbCiYcbiDf1S1WspkjqO164WX/WRmdnYodotyT +F2sTde9IIiulCPuGOpRAXG1yJ2pH+LC2+01hbN/iRZq27IIAGGh0XH8Tn1yyoPU6sn5 iM5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=V1evJkA2gwIk5oEyT4uEymgIKuSV8TFe6/i7O0mtEV4=; b=cdWETopMCCwyFf1y4aHdod9NUNT19zRiFEKIl+BDw47+JBGFA+5Fxyc3hJLHuuXdqI dF7aelVI4x1YhcK4Jhj/crcUfnh/T+RRQOz6pMEhyPYddkNm3O0Gmo1fA2GvWqEl3BhX /TQFuX7cfPW/wrvIO/umLvqpBQXDGVHRY9u5gtmIi1bQy017noeDUOzt+XsAtngGz8P4 g4LJ6p0Abg13+jTb3RB4UcX4+r61yW85jiQhKm7TJ4Idib2zDabIGfrJvBaSBc9mI795 nk8nrJvJvEhlEnn2h7m1Mp2QO+jpnaPwbHQUDqCJdd1XIiWuc16mkASCF0E/grMTJc5+ mxuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OkD2Jcn4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si973724edy.478.2020.10.02.07.03.03; Fri, 02 Oct 2020 07:03:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OkD2Jcn4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387974AbgJBOBA (ORCPT + 99 others); Fri, 2 Oct 2020 10:01:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:48300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgJBOBA (ORCPT ); Fri, 2 Oct 2020 10:01:00 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 07282206CD; Fri, 2 Oct 2020 14:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601647259; bh=rZ44DDCqLqF+ItGzh+HCjnIlsvgMjNd13iwS73Wc8BM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OkD2Jcn4IL1JDZ4MTf3xPpV2eyD3WRBTryj+6MivDF+unoG88ATQiijwc4dt8lfqr 9tGx7d+ZoUOaNMM54DmPzaqks8x8JMif1mtxDq3iltdUUOJOIL0JTxDkTyKSaa1omP PsljVgMRVugIoOTJTBhRk+VrT01R0yVutM1pbcaU= Date: Fri, 2 Oct 2020 16:00:58 +0200 From: Greg Kroah-Hartman To: Peilin Ye Cc: syzbot , axboe@kernel.dk, glider@google.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Anant Thazhemadam Subject: Re: KMSAN: kernel-infoleak in scsi_cmd_ioctl Message-ID: <20201002140058.GA3475053@kroah.com> References: <000000000000a24fa705ae29dc6c@google.com> <20201002134944.GA8205@PWN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201002134944.GA8205@PWN> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 09:49:44AM -0400, Peilin Ye wrote: > On Mon, Aug 31, 2020 at 03:28:22AM -0700, syzbot wrote: > > BUG: KMSAN: kernel-infoleak in kmsan_copy_to_user+0x81/0x90 mm/kmsan/kmsan_hooks.c:253 > > CPU: 1 PID: 12272 Comm: syz-executor.3 Not tainted 5.8.0-rc5-syzkaller #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > > Call Trace: > > __dump_stack lib/dump_stack.c:77 [inline] > > dump_stack+0x21c/0x280 lib/dump_stack.c:118 > > kmsan_report+0xf7/0x1e0 mm/kmsan/kmsan_report.c:121 > > kmsan_internal_check_memory+0x238/0x3d0 mm/kmsan/kmsan.c:423 > > kmsan_copy_to_user+0x81/0x90 mm/kmsan/kmsan_hooks.c:253 > > instrument_copy_to_user include/linux/instrumented.h:91 [inline] > > _copy_to_user+0x18e/0x260 lib/usercopy.c:33 > > scsi_put_cdrom_generic_arg include/linux/uaccess.h:170 [inline] > > + Cc: Greg Kroah-Hartman > + Cc: Anant Thazhemadam > > Hi all, > > In looking at the report, I guess this patch should fix the issue, there's > a 3-byte hole in `struct compat_cdrom_generic_command`: > > [PATCH v3] block/scsi-ioctl: Prevent kernel-infoleak in scsi_put_cdrom_generic_arg() > https://lore.kernel.org/lkml/20200909095057.1214104-1-yepeilin.cs@gmail.com/ > > But I cannot verify it, since syzbot doesn't have a reproducer for it. > The patch adds a 3-byte padding field to `struct > compat_cdrom_generic_command`. It hasn't been accepted yet. Please resend it, it looks like it hasn't been taken yet :( thanks, greg k-h