From: Eric Dumazet <dada1@cosmosbay.com>
To: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] unserialized task->files changing
Date: Tue, 8 Aug 2006 12:23:09 +0200
User-Agent: KMail/1.9.1
Cc: Kirill Korotaev <dev@sw.ru>, Andrew Morton <akpm@osdl.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <44D86275.2080406@sw.ru> <20060808101208.GA25956@infradead.org>
In-Reply-To: <20060808101208.GA25956@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200608081223.10434.dada1@cosmosbay.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1066
Lines: 36

On Tuesday 08 August 2006 12:12, Christoph Hellwig wrote:
> On Tue, Aug 08, 2006 at 02:07:49PM +0400, Kirill Korotaev wrote:
> > Fixed race on put_files_struct on exec with proc.
> > Restoring files on current on error path may lead
> > to proc having a pointer to already kfree-d files_struct.
>
> This is three times the exact same code sequence, it should probably go
> into a helper:
>
> void reset_current_files(struct files_struct *files)
> {
> 	struct files_struct *old = current->files;
>
> 	task_lock(current);
> 	current->files = files;
> 	task_unlock(current);
> 	put_files_struct(old);
> }


More over I think you want to task_lock() before reading current->files 
into 'old'

task_lock(current);
old = current->files;
current->files = files;
task_unlock(current);
put_files_struct(old);

or maybe a xchg() ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/