Received: by 2002:a4f:b056:0:0:0:0:0 with SMTP id m22csp1398147ivi; Fri, 2 Oct 2020 09:10:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxikRGpn7MraP2F5vXyCcEds/TE2yXlxO08njwZxZAgyxo9vFwc4LU/rmSothPM3juG6jdv X-Received: by 2002:a05:6402:8d3:: with SMTP id d19mr3106917edz.68.1601655000108; Fri, 02 Oct 2020 09:10:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601655000; cv=none; d=google.com; s=arc-20160816; b=Q+lGiEiIrppY9bMqfyRfdmK7z4/iZ2egChQYrLK7CzjbNA1vttkFSWnniMYT/5PySv DYXxD9YLjl4DocGfvKf+ow1UVCFBbIdx6XuB6wQF+CthnvbH5YVWCJQhDHttUFETTyLy awx9ST6XKTYtlcVDYvB5nlA7Q7NsSVDBU/+AIL1svIFbZCtDJDAW7BAqcY7U69szf2lD +Z9OjHKJgy+39QjbrxjHTwDpcSudSCJ/Am9KhvRS/hOa5lCqhvh4OnMYb1twHZ8c6Zs3 ECbh0lfW2U6TuLVwBhpslvf0/A/oAy13fUHqN9rtYMHvmgKAfIpq40T+v4jhWeL2Y9lQ C6jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=RQySGWJKhWCducdKaKDs94DbdVmYQCaWnV1LfzwjEmc=; b=XDL1fAVZ6uACybjwtcG90mR7xigdnWggxC3HtgHpil3rMuPAU8GCIYJxoQMxq534wO EiPI9O1hrvIX5UkYQbv2K/Fs947iOlWlXFfBgvpAM9NME/jp2ntWYFpu9jzaishgeMt5 on1tsOBT3O46tzXKlEBFSUoXXLpUVB12G/oYm/KzFmrCR4Sgat9lvqQunvMdcadea5tk WQR0UcxlSsxmIGxb4Z66UyRYQntonGySxZtV3T8kPYWbsoVSjpFJxK3Bg/eS78chbGCU KyLfPhiCsCYHPCrbek5RyGO8135YGZknhC1EZ0ZsQIlneCOl232JgTxc+shN+NrZfgya R87w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CoZ7r6sX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si1379803ejt.308.2020.10.02.09.09.36; Fri, 02 Oct 2020 09:10:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CoZ7r6sX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387965AbgJBQIa (ORCPT + 99 others); Fri, 2 Oct 2020 12:08:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:46706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733260AbgJBQIa (ORCPT ); Fri, 2 Oct 2020 12:08:30 -0400 Received: from [192.168.1.74] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net [75.58.59.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52A32206FA; Fri, 2 Oct 2020 16:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601654909; bh=e+lHvHZKEvcifClxl+8tPEAdY7A3K/44PBL/+/xeXRo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=CoZ7r6sXBNsJ64TKf9bQ4lMf/IJp008DyMzHkFU0lDghcsroxj1LwAsOeU/rP+BQM 7v7xMwTYX1eGkQ8AiJ8t7LoM0oDIZBkXpauh06nvcdNsvBpVPyX8sxGOZXSbX5r+hp BPgiiYzV0RPlYXriAS+WOh7LTgLRSWIBw4gYMFTs= Subject: Re: [PATCH v6 4/5] PCI: only return true when dev io state is really changed To: Ethan Zhao , bhelgaas@google.com, oohall@gmail.com, ruscur@russell.cc, lukas@wunner.de, andriy.shevchenko@linux.intel.com, stuart.w.hayes@gmail.com, mr.nuke.me@gmail.com, mika.westerberg@linux.intel.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@linux.intel.com, sathyanarayanan.kuppuswamy@intel.com, xerces.zhao@gmail.com References: <20200930070537.30982-1-haifeng.zhao@intel.com> <20200930070537.30982-5-haifeng.zhao@intel.com> From: Sinan Kaya Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: <52e9ba48-2789-31b8-b80c-23854190c4d4@kernel.org> Date: Fri, 2 Oct 2020 12:08:27 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200930070537.30982-5-haifeng.zhao@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/2020 3:05 AM, Ethan Zhao wrote: > When uncorrectable error happens, AER driver and DPC driver interrupt > handlers likely call > > pcie_do_recovery() > ->pci_walk_bus() > ->report_frozen_detected() > > with pci_channel_io_frozen the same time. We need some more data on this. If DPC is supported by HW, errors should be triggered by DPC not AER. If I remember right, there is a register that tells which AER errors should be handled by DPC.