Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1478360pxk; Fri, 2 Oct 2020 10:27:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzanKKUB587Uh5Ceg9If++VPI3DemwEr1gz51zK03csmL3StyyBxyP/QTJO0Keho8ieBQJg X-Received: by 2002:a50:9e82:: with SMTP id a2mr3494217edf.117.1601659644480; Fri, 02 Oct 2020 10:27:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601659644; cv=none; d=google.com; s=arc-20160816; b=wapCg7ONfDKzZISVHJjdeMLuMIkBhdF7kpT3uV1T7pMDJ83umJAUsnXVwNgfmcLYJ9 0O/Uho/cjA+JKrH/1GLnsh68g0XAZIeKiz6LwIkVz6ATVsS53jOXpWlU2PEhC9ydoafU cElLyY3c74MdIP+90Zkhy6KXaw8MyMDidMeBx+M19EZmmonZg4xPE6UJ4MmKOLpiW2FQ YIbVDLDKzIrAXq4XE1/ZtMQZXGFndJX5fHxjN19E70hkjRWd9SKEkJfBPDqmZ2jEeZye N9RLTknCT/26U94RIuQQZxAQNzpj2YviIxhmn9q1c/sUjHGxMZn1inDctLOOy5QvoHNt v38w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=weNRSzTouhN5dq5HbCM2jW0fQZ04bWCbjZE7fYQTn7g=; b=xB9krMXJvZsJt7uqLaI1XLc1gQpGB0Ou4a15nXxhekOyZZ65coEOOlds4ZpXI3JDbl OyAVoS34lCMXouCvJFDmN7ArPDzQmv3kWKHwlX3xa+1fULi7gTliqAie1XGKGPPXAI2U YJVh3dKPPq3wIcJVGqp1f/MoBj+xN7fx9FxpdWVO59hFgNrAMJeZ59xA4UOaoEJ51hyy Y9wEwLKuRStyyekLuZrLJTmjGiBvistGTrSmNpJ8oYuePbqFCxvwzfs4Ojgw5M/4sKH4 YzI5Okpll8WB9g9RH0sd535CUFmPJjpnFVp21ZhCZcp0DlUeySXtynG0cRjRiXVgqKuz FS3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h1si1416098edn.39.2020.10.02.10.27.00; Fri, 02 Oct 2020 10:27:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388184AbgJBRZP (ORCPT + 99 others); Fri, 2 Oct 2020 13:25:15 -0400 Received: from mga18.intel.com ([134.134.136.126]:24397 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387908AbgJBRZO (ORCPT ); Fri, 2 Oct 2020 13:25:14 -0400 IronPort-SDR: E6x0IsYRvHh8C9Zu2q+ILwXR4AA/AOhVhWXoGc7NQAYfrD6Y+qbKAgMLsBa+WADb9dBFxu9nhL tbrI5zl3IjxA== X-IronPort-AV: E=McAfee;i="6000,8403,9762"; a="150821320" X-IronPort-AV: E=Sophos;i="5.77,328,1596524400"; d="scan'208";a="150821320" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 10:25:10 -0700 IronPort-SDR: e93i4pwIcZe1gK2NkkYptPG2tZYFvx3QtVyNfyaGPZR4QI/CGA50vk1KPc6ZiZTVVznQsp/tMd 3tBggHKjJs2A== X-IronPort-AV: E=Sophos;i="5.77,328,1596524400"; d="scan'208";a="351652036" Received: from blbiskey-mobl.amr.corp.intel.com (HELO [10.212.50.43]) ([10.212.50.43]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 10:25:09 -0700 Subject: Re: [RFC PATCH 22/22] x86/fpu/xstate: Introduce boot-parameters for control some state component support To: "Chang S. Bae" , tglx@linutronix.de, mingo@kernel.org, bp@suse.de, luto@kernel.org, x86@kernel.org Cc: len.brown@intel.com, jing2.liu@intel.com, ravi.v.shankar@intel.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20201001203913.9125-1-chang.seok.bae@intel.com> <20201001203913.9125-23-chang.seok.bae@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <2497634d-162e-98d0-d51b-15265616d036@intel.com> Date: Fri, 2 Oct 2020 10:25:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201001203913.9125-23-chang.seok.bae@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/1/20 1:39 PM, Chang S. Bae wrote: > + if ((custom & XFEATURE_MASK_XTILE) != XFEATURE_MASK_XTILE) { > + pr_warn("x86/fpu: Disable 0x%x components due to incorrect setup\n", > + XFEATURE_MASK_XTILE); > + custom &= ~(XFEATURE_MASK_XTILE); > + } Saying "incorrect setup" is pretty much just wasting the bytes. We might as well just say "disabling due to random error", or "disabling due to the easter bunny". Each are equally actionable. How about: "error in xstate.disable parameter. Additionally disabling '%s'".