Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] cpupower: Provide online and offline CPU information
To:     Brahadambal Srinivasan <latha@linux.vnet.ibm.com>,
        shuah@kernel.org, trenn@suse.com
Cc:     Janakarajan.Natarajan@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "Pavithra R . Prakash" <pavrampu@in.ibm.com>,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20200929131108.19435-1-latha@linux.vnet.ibm.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <6694193a-f44e-1239-26c2-7e01650964fc@linuxfoundation.org>
Date:   Fri, 2 Oct 2020 11:27:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200929131108.19435-1-latha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/29/20 7:11 AM, Brahadambal Srinivasan wrote:
> When a user tries to modify cpuidle or cpufreq properties on offline
> CPUs, the tool returns success (exit status 0) but also does not provide
> any warning message regarding offline cpus that may have been specified
> but left unchanged. In case of all or a few CPUs being offline, it can be
> difficult to keep track of which CPUs didn't get the new frequency or idle
> state set. Silent failures are difficult to keep track of when there are a
> huge number of CPUs on which the action is performed.
> 
> This patch adds helper functions to find both online and offline CPUs and
> print them out accordingly.
> 
> We use these helper functions in cpuidle-set and cpufreq-set to print an
> additional message if the user attempts to modify offline cpus.
> 
> Reported-by: Pavithra R. Prakash <pavrampu@in.ibm.com>
> Signed-off-by: Brahadambal Srinivasan <latha@linux.vnet.ibm.com>
> ---
>   tools/power/cpupower/utils/cpufreq-set.c     |  3 +
>   tools/power/cpupower/utils/cpuidle-set.c     |  4 ++
>   tools/power/cpupower/utils/cpupower.c        |  8 +++
>   tools/power/cpupower/utils/helpers/helpers.h | 12 ++++
>   tools/power/cpupower/utils/helpers/misc.c    | 66 +++++++++++++++++++-
>   5 files changed, 92 insertions(+), 1 deletion(-)
> 

Please elaborate the changes made since v1.

I am seeing compile warnings. Please fix and send v3.

utils/cpufreq-set.c: In function ‘cmd_freq_set’:
utils/cpufreq-set.c:332:2: warning: implicit declaration of function 
‘print_offline_cpus’ [-Wimplicit-function-declaration]
   332 |  print_offline_cpus();
       |  ^~~~~~~~~~~~~~~~~~
   CC       utils/cpupower-set.o
   CC       utils/cpupower-info.o
   CC       utils/cpuidle-info.o
   CC       utils/cpuidle-set.o
utils/cpuidle-set.c: In function ‘cmd_idle_set’:
utils/cpuidle-set.c:187:2: warning: implicit declaration of function 
‘print_offline_cpus’ [-Wimplicit-function-declaration]
   187 |  print_offline_cpus();

thanks,
-- Shuah