Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
Subject: Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized
From:   John Donnelly <john.p.donnelly@oracle.com>
In-Reply-To: <9c22ec6b-7487-300b-e376-b05297a5d0bc@oracle.com>
Date:   Fri, 2 Oct 2020 13:08:06 -0500
Cc:     linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        martin.petersen@oracle.com, bstroesser@ts.fujitsu.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <0E12A198-4C8D-4A24-946C-CF9DC74500AB@oracle.com>
References: <20200924001920.43594-1-john.p.donnelly@oracle.com>
 <9c22ec6b-7487-300b-e376-b05297a5d0bc@oracle.com>
To:     Mike Christie <michael.christie@oracle.com>
Precedence: bulk


> On Oct 2, 2020, at 1:01 PM, Mike Christie =
<michael.christie@oracle.com> wrote:
>=20
> On 9/23/20 7:19 PM, john.p.donnelly@oracle.com wrote:
>> From: John Donnelly <john.p.donnelly@oracle.com>
>>=20
>> corrects: drivers/target/target_core_user.c:688:6: warning: 'page' =
may be used
>> uninitialized
>>=20
>> Fixes: 3c58f737231e ("scsi: target: tcmu: Optimize use of
>> flush_dcache_page")
>>=20
>> To: linux-scsi@vger.kernel.org
>> Cc: Mike Christie <michael.christie@oracle.com>
>> Signed-off-by: John Donnelly <john.p.donnelly@oracle.com>
>> ---
>> drivers/target/target_core_user.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/target/target_core_user.c =
b/drivers/target/target_core_user.c
>> index 9b7592350502..86b28117787e 100644
>> --- a/drivers/target/target_core_user.c
>> +++ b/drivers/target/target_core_user.c
>> @@ -681,7 +681,7 @@ static void scatter_data_area(struct tcmu_dev =
*udev,
>> 	void *from, *to =3D NULL;
>> 	size_t copy_bytes, to_offset, offset;
>> 	struct scatterlist *sg;
>> -	struct page *page;
>> +	struct page *page =3D NULL;
>>=20
>> 	for_each_sg(data_sg, sg, data_nents, i) {
>> 		int sg_remaining =3D sg->length;
>>=20
>=20
> Looks ok for now. In the next kernel we can do the more invasive =
approach and
> add a new struct/helpers to make the code cleaner and fix it properly.
>=20
> Acked-by: Mike Christie <michael.christie@oracle.com>


Hi=20

Thank you.

I am not always on the email dlists .. Please do the right thing .=20