Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1508778pxk; Fri, 2 Oct 2020 11:14:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoLsC3YXB9R3H1coSsMWlkWf/XEDWWnovfst/TKwmdpExKgVDrp0+5DXGC1FRI2cK6GMoY X-Received: by 2002:a17:906:4cc2:: with SMTP id q2mr3728596ejt.422.1601662496707; Fri, 02 Oct 2020 11:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601662496; cv=none; d=google.com; s=arc-20160816; b=gA5IOie37wgnzOBDetv8qS8HkXN/fQX7mb0HvgaPTGaymL12ij2b0PSH60I+6z1oZp fMItUii/vB447Ikuw9eG2eTBuNbUO88QdZDVB1Cm+IMFryE5JRmfWZI6BtxOYvFZLptE PeOyj7UVbxfJ6lP9jtwzVEObvNERco3b+z0Z/wrti34lus1rXawRV998oAbJJppjX/3p L2gnb3mAcjpzNv0VmUiWpwQSnGLD2XppjY/jzew8UPv7t80lQhr9IAqbiBusmwLyi57C ZHiti2SQBNRRjbcVQXC3eGSukIdu+v7KBWhqHT8zo1yTsmuqzoGgEmQIMWMfoae106Pw KKow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=s7lOqQFyYTP8OA69M9hc7vkOqgIvfro4LzsAQjPCpFk=; b=tPmO2TKhzWecd0uTsyRaGEvrbMal+s8Jl5S8OgOyZnRd6+riNsLnlArUfhBrqyH4ez ltrk/fAOh3BsyxvOiBxi7WQ0z/5WMbWkowpwa4t4Fk9WE475hX05UtRYn5TQP4ZFTrhU 7ygzmdT7nV9poa0a0dz7rhzdCScZP4OoiPAnXroEzej81BSTkbjb7ZpLcZ33NcbC7L5x QFj4abO3Jkf7v103uT8h1jBubV+pHyzwuQGHiAK/1QqNqWdMpdn7ireHJtvMDOP6MBxn lkUVafjKe7Uu4smcFd9vX6s/1uK/gd8dLx3BoabU9rXjBwNuO0jYtBHcv21A7eycDxx9 JrLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si1621617edk.57.2020.10.02.11.14.34; Fri, 02 Oct 2020 11:14:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388317AbgJBSNk (ORCPT + 99 others); Fri, 2 Oct 2020 14:13:40 -0400 Received: from mga12.intel.com ([192.55.52.136]:13505 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgJBSNk (ORCPT ); Fri, 2 Oct 2020 14:13:40 -0400 IronPort-SDR: uNlKQPiu3XFayxxg1r46oUUSpU8JimzfwK7/e+fJxkgDQdf2nNuceys53nMPmzFcJAfvIZV1oa OTekc8lHrFng== X-IronPort-AV: E=McAfee;i="6000,8403,9762"; a="142438986" X-IronPort-AV: E=Sophos;i="5.77,328,1596524400"; d="scan'208";a="142438986" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 11:13:13 -0700 IronPort-SDR: sqBVUTZY/QMV4+DTdD+AaFtzRWUyVljfVSB8nPqZaakwZyUhBkyuCcDP1rHYzY2QajlOBmYmow m2kgkEyo2fvw== X-IronPort-AV: E=Sophos;i="5.77,328,1596524400"; d="scan'208";a="385932222" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 11:13:10 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kOPYG-003nRj-P4; Fri, 02 Oct 2020 21:13:04 +0300 Date: Fri, 2 Oct 2020 21:13:04 +0300 From: Andy Shevchenko To: Rahul Tanwar Cc: jdelvare@suse.com, linux@roeck-us.net, p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, songjun.Wu@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, rtanwar@maxlinear.com Subject: Re: [PATCH v4 2/2] Add hardware monitoring driver for Moortec MR75203 PVT controller Message-ID: <20201002181304.GJ3956970@smile.fi.intel.com> References: <20201002181135.GI3956970@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201002181135.GI3956970@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 09:11:35PM +0300, Andy Shevchenko wrote: > On Fri, Oct 02, 2020 at 03:04:27PM +0800, Rahul Tanwar wrote: ... > > + case hwmon_in: > > + if (attr == hwmon_in_input) > > + return 0444; > > > + return 0; > > > + default: > > > + return 0; > > break here and > > > + } > > return 0; here only once. This probably makes little sense. -- With Best Regards, Andy Shevchenko