Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1589825pxk; Fri, 2 Oct 2020 13:38:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOZOveXLRyBecV1MfQYOKR9Zis1KZfnVFWkDtOsQFWVXSVpyCF5Ag/qOzuBFRnGaQW7Tp6 X-Received: by 2002:aa7:d4d4:: with SMTP id t20mr4513597edr.229.1601671080549; Fri, 02 Oct 2020 13:38:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601671080; cv=none; d=google.com; s=arc-20160816; b=XvVV/W9RjxXWX1XvVDs7eyd9ek3r9pRzpaLetlSX7Kel5NkYAtu8Xk+hcFGF6wmPHh 8jPg4RVNlp9wYgxl6DGRqLjQuD0XahPmXmZZr2pWmF5ezf8GCrA8vhm9pLLqbyBuoyb5 dQTr3vaULcRGbTzEaqAd7I9TJTX9+vFMRl6avx6qUUMpha9pINVb1dn8wZOp+4wGLtaC iDpVTSQwdvBrFyEfHuNIWBMIhP5Y4hCXQQkJS+wBChXhKDsH2GlxklOIel09A3GXby/c 0GCp4e2NgYJx4bhuXG9hU2/j8g++7TlcLWugSVgzxekro7tNnjIoPDmTt56qZlllTStb nrOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=TlHl6IGxXO+eItteUzF9ac58nNpRMR2snFsgmf5UIaw=; b=VVbLMrP5XLyVv7TDw/AiYRHew6iKWhT8LBC9IJqBFVh67BhKdJR5ojJxfj2s/bhxYq 08iUezEI89ctblEx4JzEbxMQFS5MQNiEhlohcbZa5xEe1laZEclvO26BKb3e6BwbC9my 9bUWjmpPp3hqwU9BP8ykYoD2gsVOTGMSgBgX1QFXIaX+CcDrwmNUGBYIHP/BPihARIMV 2LgZtkkZYoKQZ7zFWT57CSqLDW7uLhUvx34WC6mU2rUPYnkHbYMB1b6QIryhzge5hvx+ UYgtUfBwa5Ew2xdRMel2JW5xHbOOAsIlQulWMO47GfO7li33iVDm+qQiZT8F9Sq/7Lod WO2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i10si1844570edr.13.2020.10.02.13.37.37; Fri, 02 Oct 2020 13:38:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725766AbgJBUgY (ORCPT + 99 others); Fri, 2 Oct 2020 16:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgJBUgY (ORCPT ); Fri, 2 Oct 2020 16:36:24 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F1EDC0613D0; Fri, 2 Oct 2020 13:36:24 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1360611E3E4C0; Fri, 2 Oct 2020 13:19:36 -0700 (PDT) Date: Fri, 02 Oct 2020 13:36:23 -0700 (PDT) Message-Id: <20201002.133623.1599844259414142485.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, vladimir.oltean@nxp.com, olteanv@gmail.com Subject: Re: [PATCH net-next 0/4] net: dsa: Improve dsa_untag_bridge_pvid() From: David Miller In-Reply-To: <20201002024215.660240-1-f.fainelli@gmail.com> References: <20201002024215.660240-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 02 Oct 2020 13:19:36 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Thu, 1 Oct 2020 19:42:11 -0700 > Hi David, Jakub, > > This patch series is based on the recent discussions with Vladimir: > > https://lore.kernel.org/netdev/20201001030623.343535-1-f.fainelli@gmail.com/ > > the simplest way forward was to call dsa_untag_bridge_pvid() after > eth_type_trans() has been set which guarantees that skb->protocol is set > to a correct value and this allows us to utilize > __vlan_find_dev_deep_rcu() properly without playing or using the bridge > master as a net_device reference. Series applied, thanks.