Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 2 Oct 2020 19:07:48 -0500
From:   "Gustavo A. R. Silva" <gustavoars@kernel.org>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH][next] block: scsi_ioctl: Avoid the use of one-element
 arrays
Message-ID: <20201003000748.GB13557@embeddedor>
References: <20201002231033.GA6273@embeddedor>
 <ea92a55b-d12c-357e-62b2-879643ae18ce@kernel.dk>
 <20201003000338.GA13557@embeddedor>
 <c06da705-3151-0902-066a-92d2e7c558bd@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c06da705-3151-0902-066a-92d2e7c558bd@kernel.dk>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Oct 02, 2020 at 05:58:33PM -0600, Jens Axboe wrote:
> >>> -	void			__user *reserved[1];	/* unused, actually */
> >>> +	union {
> >>> +		void		__user *reserved[1];	/* unused, actually */
> >>> +		void            __user *unused;
> >>> +	};
> >>
> >> What's the point of this union, why not just turn it into
> >>
> >> 	void *			__user *unused;
> >>
> >> ?
> > 
> > I just don't want to take any chances of breaking any user-space
> > application that, for some reason, may be considering that field.
> 
> I guess that's a valid concern, who knows what applications are doing
> to an ignored field.
> 
> I'll apply it, thanks.

Awesome. :)

Thanks.
--
Gustavo