Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1729024pxk; Fri, 2 Oct 2020 18:18:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnUxop5H/GFrVWpkzrdjBdWDdOMnmlZU4McTGeKaCZUQfP0Fgz777Nr9Mji/OR9OO6Ee4e X-Received: by 2002:aa7:da0f:: with SMTP id r15mr5532706eds.321.1601687915881; Fri, 02 Oct 2020 18:18:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601687915; cv=none; d=google.com; s=arc-20160816; b=ERtWj80FMqKilqc53I5rwow617vOX4CRQ1nQfNNTM9juJOoofik9P131roRAoz8o2j An8OdlVuN3U2OLgwgSYf2mZf+J6n9RtnLsZFrgwbWViALRagNJqxd/4BoK1OVZnLlTY/ age7kjgnXty3ILYwNcTKT1uTC6rQAcou5d7SrdIYXuNOa0GGs+dP/d1Ayl8MeNgISDEH bO77SlTXbnnage/qFOW+5pZlN5f1nOuPvjuDJyQ8PUzDh5qbSmq3PPaBS9a7SEPZD37C JNCTr9gaFRVEDBBe/GUufJfzKPnrSa4qyj2DjUeNX5p4NX+g14iodmxz7W5SE43Uuj67 K7kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=abE86DuzVPBoYXarI72XFmF5L0gOwK3lw7dIMJvC8k8=; b=m165r7kii1vM3VzAOj8PtukCN8F/UlWNdjLuJIAV1HevkQ40XcCexuZKxphpCFR5bN ZzU0FiVt7plCBM+CXgL0h6hI+PqzOi/aXJhP65R8AjAXoVw8tH/5K0WycnetLX8FNwGh FwulRY/EdVJyIMzzi2LlHlGGvHj9YKt33QrhOpCN7gEnqrrpGw1b3fBf5ayCA7Xn/1NG GelBhd+rbKiKU+nzKUeOTxyI/yCML53A7x21dpe0fXKB4yUNTh2jjouQqgkMQ4oEEhFL PH5Yp8S/QJnTZNX0mlM7vYTDw3gSg0DcOXFZq1eD1KQv23SI3U8XAJrapg1rvf3AvYyk giMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=IC3RiVMn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x26si2159192edi.79.2020.10.02.18.18.14; Fri, 02 Oct 2020 18:18:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=IC3RiVMn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725768AbgJCBPT (ORCPT + 99 others); Fri, 2 Oct 2020 21:15:19 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:38954 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbgJCBPS (ORCPT ); Fri, 2 Oct 2020 21:15:18 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0931F98j019268; Sat, 3 Oct 2020 01:15:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=abE86DuzVPBoYXarI72XFmF5L0gOwK3lw7dIMJvC8k8=; b=IC3RiVMn+vJnSox7VKbbaXmukqRGZ0L7q5x64UFuNdBWXEGGv6B/4H6nTs13o2h2RbLW M/vPtMTETtK7dVlUnu0bclX99VDYuZEC2KDn/OMua1NjcehdnJN+idEvhxHYmpBrlbXG x74/Vi/dT9TEEc+sX73+ZfnW/WkkCWLhOFfDmnrBdlZmpxluZER2Pydp1if+UH6VOBOy GWjPoNYmk/xnXqduCVW0xLi8TXlkDzu615RY/9sB9kFHeRiQ9Y47klC3RaybntyDoYzy 1Hqb3FpEfViZhmz38YlCJZmAmMTRzRorxQL/3kzXwF7WN2eciHy4uckPN7nBqlYVQXUx /w== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 33xetag1td-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 03 Oct 2020 01:15:08 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0931F1iU167551; Sat, 3 Oct 2020 01:15:08 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 33xfb8g3f3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 03 Oct 2020 01:15:08 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0931F49K023571; Sat, 3 Oct 2020 01:15:06 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 02 Oct 2020 18:15:04 -0700 To: Jing Xiangfeng Cc: , , , , , Subject: Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200925060754.156599-1-jingxiangfeng@huawei.com> Date: Fri, 02 Oct 2020 21:15:02 -0400 In-Reply-To: <20200925060754.156599-1-jingxiangfeng@huawei.com> (Jing Xiangfeng's message of "Fri, 25 Sep 2020 14:07:54 +0800") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9762 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 bulkscore=0 suspectscore=1 malwarescore=0 mlxlogscore=999 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010030011 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9762 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0 clxscore=1015 priorityscore=1501 adultscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 malwarescore=0 suspectscore=1 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010030011 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jing, > ret is always zero or an error in this code path. So the assignment to > ret is redundant, and the code jumping to a label is unneed. > Let's remove them to simplify the code. No functional changes. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering