Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v6 11/14] misc: bcm-vk: add BCM_VK_QSTATS
To:     Scott Branden <scott.branden@broadcom.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Desmond Yan <desmond.yan@broadcom.com>
Cc:     Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        Olof Johansson <olof@lixom.net>
References: <20201002212327.18393-1-scott.branden@broadcom.com>
 <20201002212327.18393-12-scott.branden@broadcom.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <55f88956-48ea-08e3-c353-babb08f3a786@gmail.com>
Date:   Fri, 2 Oct 2020 18:39:12 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <20201002212327.18393-12-scott.branden@broadcom.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/2/2020 2:23 PM, Scott Branden wrote:
> Add BCM_VK_QSTATS Kconfig option to allow for enabling debug VK
> queue statistics.
> 
> These statistics keep track of max, abs_max, and average for the
> messages queues.
> 
> Co-developed-by: Desmond Yan <desmond.yan@broadcom.com>
> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>

would not it make more sense to have those debug prints be trace printks 
instead? Given what you explained in the previous patch version and the 
desire to correlate with other system wide activity, that might make 
more sense. Looking at the kernel's log for debugging performance or 
utilization or just to get a glimpse of what is going on is not quite 
suited past probe.
-- 
Florian