Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200930070537.30982-1-haifeng.zhao@intel.com>
 <20200930070537.30982-5-haifeng.zhao@intel.com> <52e9ba48-2789-31b8-b80c-23854190c4d4@kernel.org>
In-Reply-To: <52e9ba48-2789-31b8-b80c-23854190c4d4@kernel.org>
From:   Ethan Zhao <xerces.zhao@gmail.com>
Date:   Sat, 3 Oct 2020 13:46:04 +0800
Message-ID: <CAKF3qh1Bzj6LwBU0yzvLTxSO9RTU5GrJ7PRSwMBHdFJpbFzKEA@mail.gmail.com>
Subject: Re: [PATCH v6 4/5] PCI: only return true when dev io state is really changed
To:     Sinan Kaya <okaya@kernel.org>
Cc:     Ethan Zhao <haifeng.zhao@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>, Oliver <oohall@gmail.com>,
        ruscur@russell.cc, Lukas Wunner <lukas@wunner.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Stuart Hayes <stuart.w.hayes@gmail.com>,
        Alexandru Gagniuc <mr.nuke.me@gmail.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-pci <linux-pci@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ashok.raj@linux.intel.com,
        Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Sinan,

On Sat, Oct 3, 2020 at 12:08 AM Sinan Kaya <okaya@kernel.org> wrote:
>
> On 9/30/2020 3:05 AM, Ethan Zhao wrote:
> > When uncorrectable error happens, AER driver and DPC driver interrupt
> > handlers likely call
> >
> >    pcie_do_recovery()
> >    ->pci_walk_bus()
> >      ->report_frozen_detected()
> >
> > with pci_channel_io_frozen the same time.
>
> We need some more data on this. If DPC is supported by HW, errors
> should be triggered by DPC not AER.
>
> If I remember right, there is a register that tells which AER errors
> should be handled by DPC.

When uncorrectable errors happen, non-fatal severity level, AER and
DPC could be triggered at the same time.


Thanks,
Ethan

>