Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1883661pxk; Sat, 3 Oct 2020 00:53:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMWmSGaG3Thn/YN+7HbyutiYFHq/t5NWWG1LwzUNiT3Dv8Lxa1KfhiUM2jp2WUV6mXWXyy X-Received: by 2002:aa7:db02:: with SMTP id t2mr6854887eds.95.1601711632565; Sat, 03 Oct 2020 00:53:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601711632; cv=none; d=google.com; s=arc-20160816; b=gsj3d3+QpuaRBQJCvq+1/FXMwy0odjP/llIDfmWWGkG5sOsIewZE7FmszHo5OuC72E Bc7lf31WuKpl00PPsyXrGNEo3iZGR3Q5q4su8Gy+0eDpxyIn+UvIW7Oz0i4oI7urFa0k oPF9L6xbDIYEqoXf0a9Tjb31ypE2huSze7HHqxP2Ybn6MH+fv/6qhVcTX6nNwyPCJns8 Cdav1rjebveN1Ysb+LgF4vQ2Hbm/TlpQ0qvt4dBLSoEpoMtWSGfk4zpdx2hK0joomgZq cL3m2rYSyH5tvDJC9mpmsXKonfmzKm95k2AZadknuatODnS8E7N8HVlj0cq1Uuqx7CSt AXFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=k2ZUOGVbagWt3EpJ+oMKDCHsZP+OazieIj8l7AmZJ0o=; b=nXlrgJIYdVzXChlyQn4xiMjMiyfWPD3kh0BN/qOV0Oiehv22qUaD4qsAS9fQPcesFZ oGsOoStv/XxjVI6Dl3HlENJA1FP1fEOehM3EdXrXezntax+kJMHWmvg5JqYWDFAFIMcV 9dhcVczAiSjZwYhSaBvmBqJQWHbRqh990I45dqqNZ3lz28Xqg6hrelaelz3yfYI+o1AT S21VL9/CuFTI3nHMEMMzoqoq1MaxQhrENfHm1f9tF4/5f0WTVGD+snGxLE4OsjlOjHqw Xfgs7OZ2q7Q2IbN1NShlxShQhvXM1qlqwNqsTJeOyZ2cPNt+GJVvsppoGPRpE2tK33Mw wotA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=aXqNSfWi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d8si222932edy.345.2020.10.03.00.53.30; Sat, 03 Oct 2020 00:53:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=aXqNSfWi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725801AbgJCHvH (ORCPT + 99 others); Sat, 3 Oct 2020 03:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725648AbgJCHvF (ORCPT ); Sat, 3 Oct 2020 03:51:05 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2BEDC0613D0 for ; Sat, 3 Oct 2020 00:51:02 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j2so4187665wrx.7 for ; Sat, 03 Oct 2020 00:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k2ZUOGVbagWt3EpJ+oMKDCHsZP+OazieIj8l7AmZJ0o=; b=aXqNSfWiHGjdLU5AaDEHEnYaGYd29JMQZBGj4SAc3fivAPJhvOQ1hlBv9nsFlCsE4S lNRg2sUIqzH2OK8cuErFg9zmzFo/nVEUmMn59Mwo8pkCkffJLfQEzcc4Wk08p16+Rrew T8VK+7W1zwKNUivTBp8VvU2FW4ZSB/IhLTp0QNw/o119wqUWRrhRDahYonDP5LqUUgjD Fy2Z/cQnmmRaDWg5wjdCUlLyHieo3GgcjZ5Zvzk6j55261psIQKf6bqxFx1zZ1woJccE hbbG9MhIx3WBEzpfWdza/0PX0I/0uklTCDXFl3JW5htWa4zdZb4Cla9SDlNSsLYRD6oH W36Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k2ZUOGVbagWt3EpJ+oMKDCHsZP+OazieIj8l7AmZJ0o=; b=D6O+WoTXlgozSFO08qVTm4BGk01aunnyvTVEPRJWBeiyyKR2JMqJ9gXO/9A8S9efc4 Hd2afDEd+6SIiBhPODzZux6i0x+aR/l+yK8jq0jQSJsHLr6DDWUEPn2lf2G12qaprvUQ iQwAPkJWM9UrMo8B2vsWA8Jc4s4mvH42WGEQNQrp6eZMOSGgEIFSqz9SwrzUecCUxaIg mqDiiSrPmnWBcuz0Nt6tKtf0mIudJ+nJtVUY8/NI2BoNQxbE1hlXsO9Kqtvy9Jk9yM6/ uoja8t3YVmXSQ3qqkKm+IuiGitpk6v96tTN4tNSu8e5ssjB7ExviDYuw8POJ8XwBvIhc rC3g== X-Gm-Message-State: AOAM533/84wnH1bgHP3Wj8au6dnJYa3pZBf9fJz5vLlrxkR/V0fJYfQX ygpC/L4COr3HaOX9WsBJwsvW2g== X-Received: by 2002:adf:f504:: with SMTP id q4mr6938574wro.353.1601711461444; Sat, 03 Oct 2020 00:51:01 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id i14sm4780622wro.96.2020.10.03.00.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2020 00:51:00 -0700 (PDT) Date: Sat, 3 Oct 2020 09:51:00 +0200 From: Jiri Pirko To: Moshe Shemesh Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option Message-ID: <20201003075100.GC3159@nanopsycho.orion> References: <1601560759-11030-1-git-send-email-moshe@mellanox.com> <1601560759-11030-4-git-send-email-moshe@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1601560759-11030-4-git-send-email-moshe@mellanox.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, Oct 01, 2020 at 03:59:06PM CEST, moshe@mellanox.com wrote: [...] > enum devlink_attr { > /* don't change the order or add anything between, this is ABI! */ > DEVLINK_ATTR_UNSPEC, >@@ -507,6 +524,7 @@ enum devlink_attr { > > DEVLINK_ATTR_RELOAD_ACTION, /* u8 */ > DEVLINK_ATTR_RELOAD_ACTIONS_PERFORMED, /* u64 */ >+ DEVLINK_ATTR_RELOAD_LIMIT, /* u8 */ Hmm, why there could be specified only single "limit"? I believe this should be a bitfield. Same for the internal api to the driver. [...]