Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 3 Oct 2020 15:56:00 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     ultracoolguy@tutanota.com
Cc:     Dmurphy <dmurphy@ti.com>, Linux Leds <linux-leds@vger.kernel.org>,
        Trivial <trivial@kernel.org>, linux-kernel@vger.kernel.org,
        marek.behun@nic.cz
Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access
Message-ID: <20201003135600.GA25460@duo.ucw.cz>
References: <MIiYgay--3-2@tutanota.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="5mCyUwZo2JvN/JJP"
Content-Disposition: inline
In-Reply-To: <MIiYgay--3-2@tutanota.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--5mCyUwZo2JvN/JJP
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Signed-off-by: Ultracoolguy <ultracoolguy@tutanota.com>

I'll need your real name to apply a patch.

> Hi, all. This is a patch fixing an out-of-bounds error due to lm3697_init=
 expecting the device tree to use both control banks.=A0 This fixes it by a=
dding a new variable that will hold the number of used banks.
>=20
> Panic caused by this bug:

> <7>[=A0=A0=A0 3.059893] CPU: 3 PID: 1 Comm: swapper/0 Tainted: G=A0=A0=A0=
=A0=A0=A0=A0 W=A0=A0=A0=A0=A0=A0=A0=A0 5.9.0-rc7-postmarketos-qcom-msm8953 =
#71

Ok, so I assume this is only problem with certain device trees, and
not a problem with dts' in mainline?

This is not trivial patch, no need to cc trivial tree. OTOH Ccing
Marek who did a lot of cleanups in -next might be useful. Doing that
now.

Best regards,

									Pavel
--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--5mCyUwZo2JvN/JJP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX3iC8AAKCRAw5/Bqldv6
8sa3AJ9JF0aojI2xKqcCGsgNFNF9jNonnACff9gr5JH8H6PkzXYth1TF7HrA/hI=
=Vfbg
-----END PGP SIGNATURE-----

--5mCyUwZo2JvN/JJP--