Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201003173528.41404-1-xie.he.0141@gmail.com> <20201003110958.5b748feb@hermes.local>
In-Reply-To: <20201003110958.5b748feb@hermes.local>
From:   Xie He <xie.he.0141@gmail.com>
Date:   Sat, 3 Oct 2020 14:27:37 -0700
Message-ID: <CAJht_ENGQNFoD23G9QR6ETH_AZZS8p5Zw4y=+=nHKrhbNe3H0A@mail.gmail.com>
Subject: Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Reduce indentation in pvc_xmit
To:     Stephen Hemminger <stephen@networkplumber.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Krzysztof Halasa <khc@pm.waw.pl>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 3, 2020 at 11:10 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> This code snippet is basically an version of skb_pad().
> Probably it is very old and pre-dates that.
> Could the code use skb_pad?

Oh! Yes! I looked at the skb_pad function and I think we can use it in
this code.

Since it doesn't do skb_put, I think we can first call skb_pad and
then call skb_put.

Thanks for your suggestion. I'll change this patch to make use of
skb_pad and re-submit.