Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 03 Oct 2020 16:42:40 -0700 (PDT)
Message-Id: <20201003.164240.1313265831717025751.davem@davemloft.net>
To:     weifeng.voon@intel.com
Cc:     mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, joabreu@synopsys.com,
        peppe.cavallaro@st.com, andrew@lunn.ch, alexandre.torgue@st.com,
        boon.leong.ong@intel.com, chen.yong.seow@intel.com,
        mgross@linux.intel.com, vee.khee.wong@intel.com
Subject: Re: [PATCH v2 net] net: stmmac: Modify configuration method of EEE
 timers
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20201001155609.5372-1-weifeng.voon@intel.com>
References: <20201001155609.5372-1-weifeng.voon@intel.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: Voon Weifeng <weifeng.voon@intel.com>
Date: Thu,  1 Oct 2020 23:56:09 +0800

> From: "Vineetha G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>
> 
> Ethtool manual stated that the tx-timer is the "the amount of time the
> device should stay in idle mode prior to asserting its Tx LPI". The
> previous implementation for "ethtool --set-eee tx-timer" sets the LPI TW
> timer duration which is not correct. Hence, this patch fixes the
> "ethtool --set-eee tx-timer" to configure the EEE LPI timer.
> 
> The LPI TW Timer will be using the defined default value instead of
> "ethtool --set-eee tx-timer" which follows the EEE LS timer implementation.
> 
> Fixes: d765955d2ae0 ("stmmac: add the Energy Efficient Ethernet support")
> Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com>
> Signed-off-by: Voon Weifeng <weifeng.voon@intel.com>
> 
> Changelog V2
> *Not removing/modifying the eee_timer.
> *EEE LPI timer can be configured through ethtool and also the eee_timer
> module param.
> *EEE TW Timer will be configured with default value only, not able to be
> configured through ethtool or module param. This follows the implementation
> of the EEE LS Timer.

Please put the Changelog above the various signoffs and other tags, as those
should be at the end of the commit log message.

Just out of curiousity, where did you see put the changelog after the
tags, and thus caused you to use this layout?  If you decided that on
your own, this is pretty much always a bad idea.  Look to other
patches which have been accepted as a guide for how to format your commit
log message.

Applied, thank you.