Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2341073pxk;
        Sat, 3 Oct 2020 17:40:07 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxjv/hjQrYKO+1K4JWBDoaHvTedG8uFXKWHYV2327nXanGqa9VnRpWLuYhaVPGjoByH1Q0V
X-Received: by 2002:a05:6402:17b5:: with SMTP id j21mr10293101edy.276.1601772007593;
        Sat, 03 Oct 2020 17:40:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1601772007; cv=none;
        d=google.com; s=arc-20160816;
        b=R77zYh92awlMRg1JCe2eNF651rIZhXsyDpeMCxTNt4grBRmB34NvITwdqvEMEuCGEU
         PXfCYsrsIlQCon0UyB45lj9FN0h7cf+Dba8Sn/Bx9lTe9WpykfiEtmTnZYrxwNGO6u5q
         WjQjm7y+9kGv9WG947n/d1f5DnT0NRmHFaiGu+GonV6f4YwasZws6agRcbOo6273GsuD
         9nsHeyfsrdL520H2uClFONcTWccoMpL34byX6simWg2skbfiZGIOId7AViQsVChM2YcY
         JI4JjvYdlYugdI0KWp4RcydKisbb+Wr6ZlsGRHACqZ20XvP+tm9yLTb+6x01vBO3Qp1U
         OjLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=TiNuOdyMRlGgPzwVOx//dwFVWdvFWcHEf3VkGrfXrQA=;
        b=ufS7RSCaYFRevqDJbju4BsV07ohB2EHwFtFXrB6IC0JPuVcsV+UOBXE6BJ4lAPiQlt
         vfne0XnvPmBWnXQw1c21R8I+Kksnto/NFtzOiQ/4vGVU/aUJnfYPQ9ZjfwScouzc/b2M
         Edw2Icq3IRKwUIrz+i9tu2mZn6bOj59j/dSRijpugOoVV4HFkVFMQEL36Kq69351wgLH
         khmDjT8jHb5bvJaBg5ouFRHdohTXzHnF1EoS7sVgv46dpwJG07m7DRFMjqQbTaQx/7Gn
         Ym5ud47Md6Co8Q2WWQpo6uMl/tuut/5TmAdmseuPnjj9t6aI9QbWJOdJftVFPuYKINcD
         CQWA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id y5si4320380edo.449.2020.10.03.17.39.45;
        Sat, 03 Oct 2020 17:40:07 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726259AbgJDAgt (ORCPT <rfc822;linuxbirdgao@gmail.com>
        + 99 others); Sat, 3 Oct 2020 20:36:49 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58348 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726110AbgJDAgt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 3 Oct 2020 20:36:49 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BB1DC0613D0;
        Sat,  3 Oct 2020 17:36:49 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 4F0B711E3E4CB;
        Sat,  3 Oct 2020 17:20:01 -0700 (PDT)
Date:   Sat, 03 Oct 2020 17:36:48 -0700 (PDT)
Message-Id: <20201003.173648.767792137065746549.davem@davemloft.net>
To:     matthieu.baerts@tessares.net
Cc:     mathew.j.martineau@linux.intel.com, kuba@kernel.org,
        geliangtang@gmail.com, dcaratti@redhat.com, netdev@vger.kernel.org,
        mptcp@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20201003153656.1224144-1-matthieu.baerts@tessares.net>
References: <20201003153656.1224144-1-matthieu.baerts@tessares.net>
X-Mailer: Mew version 6.8 on Emacs 27.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Sat, 03 Oct 2020 17:20:01 -0700 (PDT)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Matthieu Baerts <matthieu.baerts@tessares.net>
Date: Sat,  3 Oct 2020 17:36:56 +0200

> The MPTCP ADD_ADDR suboption with echo-flag=1 has no HMAC, the size is
> smaller than the one initially sent without echo-flag=1. We then need to
> use the correct size everywhere when we need this echo bit.
> 
> Before this patch, the wrong size was reserved but the correct amount of
> bytes were written (and read): the remaining bytes contained garbage.
> 
> Fixes: 6a6c05a8b016 ("mptcp: send out ADD_ADDR with echo flag")
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/95
> Reported-and-tested-by: Davide Caratti <dcaratti@redhat.com>
> Acked-by: Geliang Tang <geliangtang@gmail.com>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>

Applied.