Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next 02/16] devlink: Add reload action option to
 devlink reload command
To:     Jiri Pirko <jiri@resnulli.us>, Moshe Shemesh <moshe@mellanox.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@nvidia.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1601560759-11030-1-git-send-email-moshe@mellanox.com>
 <1601560759-11030-3-git-send-email-moshe@mellanox.com>
 <20201002151943.GB3159@nanopsycho.orion>
From:   Moshe Shemesh <moshe@nvidia.com>
Message-ID: <44621685-5356-c0c2-2947-15013b8f6d13@nvidia.com>
Date:   Sun, 4 Oct 2020 09:30:48 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201002151943.GB3159@nanopsycho.orion>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 10/2/2020 6:19 PM, Jiri Pirko wrote:
> Thu, Oct 01, 2020 at 03:59:05PM CEST, moshe@mellanox.com wrote:
>
> [...]
>
>
>> diff --git a/include/net/devlink.h b/include/net/devlink.h
>> index 1c286e9a3590..ddba63bce7ad 100644
>> --- a/include/net/devlink.h
>> +++ b/include/net/devlink.h
>> @@ -1077,10 +1077,11 @@ struct devlink_ops {
>> 	 * implemementation.
>> 	 */
>> 	u32 supported_flash_update_params;
>> +	unsigned long reload_actions;
>> 	int (*reload_down)(struct devlink *devlink, bool netns_change,
>> -			   struct netlink_ext_ack *extack);
>> -	int (*reload_up)(struct devlink *devlink,
>> -			 struct netlink_ext_ack *extack);
>> +			   enum devlink_reload_action action, struct netlink_ext_ack *extack);
>> +	int (*reload_up)(struct devlink *devlink, enum devlink_reload_action action,
>> +			 struct netlink_ext_ack *extack, unsigned long *actions_performed);
> Nit. Could you please push extack to be the last arg here? It is common
> to have extack as the last arg + action and actions_performed are going
> to be side by side.


Sure.

> Otherwise the patch looks fine.
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>