Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2609720pxk; Sun, 4 Oct 2020 05:48:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEXQ2xe8mBfbXZkN6fpktGyG3+k54GJy60vOAsrVxm40+482+JXnau+bLeC6OOzc1jgJRJ X-Received: by 2002:a17:906:692:: with SMTP id u18mr10397657ejb.43.1601815732797; Sun, 04 Oct 2020 05:48:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601815732; cv=none; d=google.com; s=arc-20160816; b=NK5URpDhrKdSJGYlVLI77SKGjecKKOboCyu6Bfkt+37g5a7IKAaGw4Dc2PWai6zPjA ZZhoinXM9FpB6aGWwLC+5WEaqa8HThpprvziyAw+/NDaPdjPwyatGv3A59+IB6KaxLr2 9XIhN0WRoQ+3/vKULGHKqTBdiK/nsrerNY0hKKCKsAKP2OfOHt9ZDSXmh8vi3wrDQPDt S+Di7sEaazRm37CgM8BWXr+Fxqmkx6pq5cxh85rZQhn8mzdZYdz+0qKhrWL8RxKLGhMq 85RrJBD11A7fgZzFFIO5SihKseQAQ0edjfNEgmgqBNHh+EiIyr8dnQp00jdwr9gEuk49 Cgiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9Q/JMY0PwPNUVAuNXIdmcfoSHYhVBibB2yM+km8W46o=; b=0a3agd5tvK4jtbMKME1v8zfNKb85BbYuptvkn2VBX0oeQ4yOV69N2MpsnNmmO7JBES 3T9m8/qJ5Is8FX5r45icNZwiH4hZpTjTXEErriAeGo9DEswNqvBqCGFS6p3DIx9CB3Ar rVpOrVxJ/xmxTjxV4vfH0vMJzHo3BPxJRn0gGxdenpRPBHxZ2kDKrJS7ddecvGaQZAKa 6iqcnirXxgLK9NHTlyshgf/HPvGFCsh+fAQErhEqp02P0uTZ1liqRF+av/uzPcUCl7BX r0i9uuHSBthLEoahIRcwJv8rdAWtwdGc8pS63nfLuzGK1taDDIdPC2wobe2vws1x4Ijl MRpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=m5zXzEeV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do5si4652742ejc.752.2020.10.04.05.48.03; Sun, 04 Oct 2020 05:48:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=m5zXzEeV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726064AbgJDMqK (ORCPT + 99 others); Sun, 4 Oct 2020 08:46:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:54458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbgJDMqJ (ORCPT ); Sun, 4 Oct 2020 08:46:09 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D3D5206C1; Sun, 4 Oct 2020 12:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601815569; bh=KmlOPDI70o6oZU+d45F/jzuxfUWYoVayUg2hJ7fdtXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m5zXzEeVvnzVMH3HoN78Ppoz9GCrFs1Ea5iwlpRkhjj4Z8EntXyUUzszRNs0F6CGt wbUCUCsqOuijVE61LGLlJNdh/cuBaJaMYcBkOstJS/n5tVCx9wauqY6ZoWr5AXqfFN qtQEwDVD5415kNqCC3hxEARHAFTkhJ9DC7g3UFpM= Date: Sun, 4 Oct 2020 08:46:08 -0400 From: Sasha Levin To: Helmut Grohne Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Alexandre Belloni , "David S . Miller" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH AUTOSEL 5.8 08/29] net: dsa: microchip: look for phy-mode in port nodes Message-ID: <20201004124608.GJ2415204@sasha-vm> References: <20200929013027.2406344-1-sashal@kernel.org> <20200929013027.2406344-8-sashal@kernel.org> <20200929055630.GA9320@laureti-dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200929055630.GA9320@laureti-dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 07:56:30AM +0200, Helmut Grohne wrote: >Hi Sascha, > >On Tue, Sep 29, 2020 at 03:30:05AM +0200, Sasha Levin wrote: >> From: Helmut Grohne >> >> [ Upstream commit edecfa98f602a597666e3c5cab2677ada38d93c5 ] >> >> Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode >> property should be specified on port nodes. However, the microchip >> drivers read it from the switch node. >> >> Let the driver use the per-port property and fall back to the old >> location with a warning. >> >> Fix in-tree users. > >I don't think this patch is useful for stable users. It corrects a >device tree layout issue. Any existing users of the functionality will >have an odd, but working device tree and that will continue working >(with a warning) after applying this patch. It just has a property on >the "wrong" node. I don't think I'd like to update my device tree in a >stable update. I've dropped it, thanks! -- Thanks, Sasha