Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2734189pxk; Sun, 4 Oct 2020 10:00:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyALqbC520FJSxDYZAWAQSDqZjvYt+AD5mKvVUt8lEAg+hd/1ffgC/OjM0If08rESp7HkXc X-Received: by 2002:a17:906:dbf7:: with SMTP id yd23mr11267455ejb.281.1601830845588; Sun, 04 Oct 2020 10:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601830845; cv=none; d=google.com; s=arc-20160816; b=Qq7cUk8R0QWS2L/HKYvDk0gyXYR1xTrlAF29O4BCUne83KDO5KGPkiwAvRa33FlJwB QCKYOv97wJOuirTIUqwLWb7eFQdnrN5K24om7cjd8uvxiMPm94EWUYCvaEQtuio9gvXo f9nua0PlyCU5gfpMPkpThEyjOf+eMSZkQ2z/IIZ0ZpDtRuZoiwh4A9KnLAd1tknQggL+ dzcb4usohLJAcFWU0CnusUumpFj52lMH4SMq50yR8rGeo1du5zWUKWMvkc93dHVujDv1 +WmayYBbl4NP86gy5MhcAkJSFgorJPXqYYDwuk3Rsn5UMM03yFfgB9m3m0rH4LHMmTlP 2TxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vjNmLrioZaKomFB3DGRdxM/K7W5judjXghLG50kcans=; b=gKwWNMyxdgMJiq5bwRCiXXKmpqrNwHhKwYw17RfRW4MeGTDK0MizrVNONrAY3hp0PW cixlpx7v7elE9xA07lOTediWKz/zZff1eFoWFlSq769fiKrut9cvBZiMBQAyt+E0vYOV PB4QQc3/QN0PpZQC0sVjplyvUxxkjiCjDZC0jB5CPtgznL9mnw6Tswrw0+vnRSIubfiC Ep/ONYk2dvh8CUxbrNUQNP/8hut7+wNYNMiQ1EhtfynJXDZTMiH/GCw48wGxwDmlyIDw yOWQYB4RS4sIKwWcNUmiicwxVNok78bCU0AbVpZvUn3pTuMmbNDSeyLr/uKzN5fzBioq zBIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DKamgwob; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b25si5423385edw.586.2020.10.04.09.59.50; Sun, 04 Oct 2020 10:00:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DKamgwob; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726092AbgJDQq7 (ORCPT + 99 others); Sun, 4 Oct 2020 12:46:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:52938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbgJDQq7 (ORCPT ); Sun, 4 Oct 2020 12:46:59 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2218206B6; Sun, 4 Oct 2020 16:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601830019; bh=sVEX0xi2MOLC/1DXKNiNcCpDgAXQI03GADdRHFc9uZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKamgwob7/jlJskOlG4YZ5v6qF71gImkGZeH95aFI/LtSjGTsPI0kdInTGrTGULNf EOMLWYHZGoDfq38MqYRzaUVMLd80bhqXRpM3SsqXn/3y8dDxNtQoGo6mS8SOQR6dYS /YSh2OwwVGl6JHtT7TKTe5iDR5+g9V5vCUrVjTRQ= Date: Sun, 4 Oct 2020 18:47:45 +0200 From: Greg KH To: pierre kuo Cc: rafael@kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 2/2] driver core: platform: provide devm_platform_iounremap_resource Message-ID: <20201004164745.GA196660@kroah.com> References: <20200920113808.22223-1-vichy.kuo@gmail.com> <20200920113808.22223-2-vichy.kuo@gmail.com> <20201002134532.GA3419175@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2020 at 12:21:12AM +0800, pierre kuo wrote: > hi Greg: > > Please resend, I can't take patches off of a random web site. > > Now lore.kernel.org I could take them from :) > > Please refer to the attachments and links on lore.kernel.org. > > https://lore.kernel.org/lkml/20200920113808.22223-1-vichy.kuo@gmail.com > https://lore.kernel.org/lkml/20200920113808.22223-2-vichy.kuo@gmail.com Why are you adding new functions but not actually calling them anywhere? We don't like adding infrastructure that no one uses, that's just wasteful. Please redo the series and include some conversions as well, so that we can see if these new functions are even needed or not. thanks, greg k-h