Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 4 Oct 2020 23:55:58 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Evgeniy Polyakov <zbr@ioremap.net>,
        Angelo Dureghello <angelo.dureghello@timesys.com>,
        Akira Shimahara <akira215corp@gmail.com>
Subject: Re: [PATCH 1/3] w1: Constify struct w1_family_ops
Message-ID: <20201004215558.tx63d2twqh222vxo@earth.universe>
References: <20201004193202.4044-1-rikard.falkeborn@gmail.com>
 <20201004193202.4044-2-rikard.falkeborn@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gz6txsv2clopfftb"
Content-Disposition: inline
In-Reply-To: <20201004193202.4044-2-rikard.falkeborn@gmail.com>
Precedence: bulk


--gz6txsv2clopfftb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, Oct 04, 2020 at 09:32:00PM +0200, Rikard Falkeborn wrote:
> The fops field in the w1_family struct is never modified. Make it const
> to indicate that. Constifying the pointer makes it possible for drivers
> to declare static w1_family_ops structs const, which in turn will allow
> the compiler to put it in read-only memory.
>=20
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/w1/w1.c    | 2 +-
>  include/linux/w1.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index e58c7592008d..6bd64bcb6316 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -613,7 +613,7 @@ static int w1_uevent(struct device *dev, struct kobj_=
uevent_env *env)
> =20
>  static int w1_family_notify(unsigned long action, struct w1_slave *sl)
>  {
> -	struct w1_family_ops *fops;
> +	const struct w1_family_ops *fops;
>  	int err;
> =20
>  	fops =3D sl->family->fops;
> diff --git a/include/linux/w1.h b/include/linux/w1.h
> index cebf3464bc03..949d3b10e531 100644
> --- a/include/linux/w1.h
> +++ b/include/linux/w1.h
> @@ -269,7 +269,7 @@ struct w1_family {
>  	struct list_head	family_entry;
>  	u8			fid;
> =20
> -	struct w1_family_ops	*fops;
> +	const struct w1_family_ops *fops;
> =20
>  	const struct of_device_id *of_match_table;
> =20
> --=20
> 2.28.0
>=20

--gz6txsv2clopfftb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl96ROsACgkQ2O7X88g7
+pqtqw//ThjNx+K3dBPwn0cFexIitCRlwfUE/EM3er8mtujC2cYiU2rYH6sVUiBX
x/7P3thxU3O3Uz3QN5klVJd2nHovFc5bV1yN28Zp+HkcTHpv04+UnlNsxslYDBQa
cNvrPSOzGxOOKrZ0PBLwmsGD5v6lQ6DoZ6MXY4ltfRxII7rDuqo9lb8sscevdNJD
MjfzUBO/GjKkwfQ0irZxhUZhlfDsW04Xb4CKoPn1dVEyipmdcSPcIpY/rDA3Ghqa
SpJMNUoKLff6Cknz4A6MQYNLDQkbM1qvorc4e1BgYgwQlcwPXxfcooxQXeUUGaKL
FZ60XpoOxS7t5ltva9wX0nTxORFR1sEXak8szI8PHDfAL9a8rUbPKlVHyo8bsrkM
Ap62y+Tk0oCeBBHjnVVPqf2L3WO2JOd/QCCk45kiuMd3/H85OsftJAMMnXDieTj+
tv8KQ0oKElwPc1uZSEUhVHYxczozierW4vYMhIuTkZ/EmLJU1NkQnVZIrxQRFciI
xGguw4YqiVAztB6CvEMm1BRNY6cqAaFnN5fG6AAz+Da5QQHlrVB0fiSd2BvT/hUE
6g9JGh237LcPt2cv6lGOcXEE2kH9+BUfodB28sHNyJ4snbYq59FZcWSZhNGEm8mu
NDMihn17Iiozxu21t9+2/WuHnVOOMk8Deo4eaKOcWKNwPUpfZRY=
=d43l
-----END PGP SIGNATURE-----

--gz6txsv2clopfftb--