Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 4 Oct 2020 15:04:00 -0700
From:   Nicolin Chen <nicoleotsuka@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     thierry.reding@gmail.com, joro@8bytes.org, vdumpa@nvidia.com,
        jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device()
Message-ID: <20201004220359.GB21420@Asurada-Nvidia>
References: <20201003065947.18671-1-nicoleotsuka@gmail.com>
 <20201003065947.18671-3-nicoleotsuka@gmail.com>
 <97d69b0b-db32-08ff-0691-73cfa571f974@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <97d69b0b-db32-08ff-0691-73cfa571f974@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Sat, Oct 03, 2020 at 05:05:52PM +0300, Dmitry Osipenko wrote:
> 03.10.2020 09:59, Nicolin Chen пишет:
> >     ubuntu@jetson:~$ dmesg | grep iommu
> >     iommu: Default domain type: Translated 
> >     tegra-i2c 7000c400.i2c: Adding to iommu group 0
> >     tegra-i2c 7000c500.i2c: Adding to iommu group 0
> >     tegra-i2c 7000d000.i2c: Adding to iommu group 0
> >     tegra-pcie 1003000.pcie: Adding to iommu group 1
> 
> Could you please explain how you got I2C into IOMMU?
> 
> Are you testing vanilla upstream kerne? Upstream DT doesn't assign AHB
> group to I2C controllers, nor to APB DMA controller.

I have local DT changes adding iommus property in i2c/pcie nodes
to test group_device() and pci device, yet neither of them is in
vanilla kernel. The log is merely to show to people the sequence
of iommu core prior to clients.