Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 5 Oct 2020 00:16:45 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Joe Perches <joe@perches.com>
Cc:     Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] test_power: add missing newlines when printing
 parameters by sysfs
Message-ID: <20201004221645.nyaf7jhur4jixo6n@earth.universe>
References: <1599199798-27804-1-git-send-email-wangxiongfeng2@huawei.com>
 <20201003212336.5et7erdf6fihqscu@earth.universe>
 <472008b94f4b20915425db4714fdb505cb0cbe5a.camel@perches.com>
 <20201003215029.jsugcgpgrmcmydr3@earth.universe>
 <9822843f764520e1076a92fd9120294aa393a085.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vr4whwmim25ljj7f"
Content-Disposition: inline
In-Reply-To: <9822843f764520e1076a92fd9120294aa393a085.camel@perches.com>
Precedence: bulk


--vr4whwmim25ljj7f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, Oct 03, 2020 at 02:55:41PM -0700, Joe Perches wrote:
> On Sat, 2020-10-03 at 23:50 +0200, Sebastian Reichel wrote:
> > Hi,
> >=20
> > On Sat, Oct 03, 2020 at 02:43:09PM -0700, Joe Perches wrote:
> > > On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel wrote:
> > > > On Fri, Sep 04, 2020 at 02:09:58PM +0800, Xiongfeng Wang wrote:
> > > > > When I cat some module parameters by sysfs, it displays as follow=
s.
> > > > > It's better to add a newline for easy reading.
> > > []
> > > > > root@syzkaller:~# cd /sys/module/test_power/parameters/
> > > > > root@syzkaller:/sys/module/test_power/parameters# cat ac_online
> > > > > onroot@syzkaller:/sys/module/test_power/parameters# cat battery_p=
resent
> > > > > trueroot@syzkaller:/sys/module/test_power/parameters# cat battery=
_health
> > > > > goodroot@syzkaller:/sys/module/test_power/parameters# cat battery=
_status
> > > > > dischargingroot@syzkaller:/sys/module/test_power/parameters# cat =
battery_technology
> > > > > LIONroot@syzkaller:/sys/module/test_power/parameters# cat usb_onl=
ine
> > > > > onroot@syzkaller:/sys/module/test_power/parameters#
> > > > >=20
> > > > > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> > > > > ---
> > > >=20
> > > > Thanks, queued.
> > > []
> > > > > diff --git a/drivers/power/supply/test_power.c b/drivers/power/su=
pply/test_power.c
> > > []
> > > > > @@ -353,6 +353,7 @@ static int param_set_ac_online(const char *ke=
y, const struct kernel_param *kp)
> > > > >  static int param_get_ac_online(char *buffer, const struct kernel=
_param *kp)
> > > > >  {
> > > > >  	strcpy(buffer, map_get_key(map_ac_online, ac_online, "unknown")=
);
> > > > > +	strcat(buffer, "\n");
> > > > >  	return strlen(buffer);
> > > > >  }
> > >=20
> > > All of these would be better as sprintf(buffer, "%s\n", <whatever>)
> > > so the output is scanned just once instead of scanned three times.
> >=20
> > Agreed. Anybody willing to send a patch? :)
>=20
> Well, you _are_ the maintainer. Why not you?

I prefer to have patches reviewed and when I sent out patches for
my own subsystem I often do not get any reviews at all. From my
experience people often like to increase their patch count anyways
(e.g. because their employer wanting to see high patch count), so
asking others to write the patch is an easy workaround for me. I
then only do the leftovers.

-- Sebastian

--vr4whwmim25ljj7f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl96SccACgkQ2O7X88g7
+prN/hAAhvjucLG5mdmznzb+0h8DEKNMLC1kj95NZTvydXpmKbgWVbZbEe8vlKaG
cd783d+/CZxnrOWUQ0G+vuAHDzfySno/rkJX3hIcCQUM4lTPG7gMwnjEEtGPB8FO
oFWuMTDnKklpjgELckUg8hkZdA28HUr/QxMSBYI5sR+yJwqjGGV2ISE8LWJ+iTO+
5gCgdeSLG1+jIqFE2CMFXNo5Hy263Zj5+pz+JoNgj06NzRlH72t52VNZzMvOA+Ku
t+rHG+us35JlCbeYjJjeUOaSv3UwBS5/0LmfvXhcU+MDPMZQgFh5GDp1yfSSNF7M
VSu9gGHNrxm1zzsjQXYy/5l4oeuJuMHhT8rIX5bOIcrOGtilSPMn3jAba+lMEDy3
r/7B5sC0PWOx6k/NjJlVo4Qo/JKj1i6I9QIBqR0oxuJZW6KZcRccMFaf+ujvzz8B
+vUxiM89fEM763dOc+aj5BpbcaT4FrFtiLYg11uV6VShmQKpcuwiUj+bbXhcckC0
7p5UfeMLADdkzH/7Q7fextnZ2yoF6THNYQ1Ci3Vn/SSVTpAuKIFuQoqSGoXrnTiX
vBi5+01TjXf8yNXjSjS8GcLZeaZcW6nnckZ2+YT2CNZzHq3xC70+0GIP7bBSRSso
oEgDs8AsJTMxiAqtooDl2EwHLhh+dF33RDbOT+PZ5eyzCh4uZzo=
=yD3h
-----END PGP SIGNATURE-----

--vr4whwmim25ljj7f--