Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964962AbWHHQ0G (ORCPT ); Tue, 8 Aug 2006 12:26:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964978AbWHHQ0F (ORCPT ); Tue, 8 Aug 2006 12:26:05 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:12237 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S964962AbWHHQ0D (ORCPT ); Tue, 8 Aug 2006 12:26:03 -0400 Date: Tue, 8 Aug 2006 17:25:59 +0100 From: Christoph Hellwig To: Ananth N Mavinakayanahalli Cc: linux-kernel@vger.kernel.org, Prasanna S Panchamukhi , Anil S Keshavamurthy , Jim Keniston Subject: Re: [PATCH 2/3] Kprobes: Define retval helper Message-ID: <20060808162559.GB28647@infradead.org> Mail-Followup-To: Christoph Hellwig , Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, Prasanna S Panchamukhi , Anil S Keshavamurthy , Jim Keniston References: <20060807115537.GA15253@in.ibm.com> <20060807120024.GD15253@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060807120024.GD15253@in.ibm.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 17 On Mon, Aug 07, 2006 at 05:30:24PM +0530, Ananth N Mavinakayanahalli wrote: > From: Ananth N Mavinakayanahalli > > Add the KPROBE_RETVAL macro to help extract the return value on > different architectures, while using function-return probes. Good idea. You should add parentheses around regs, otherwise the C preprocessor might bite users. Also the shouting name is quite ugly. In fact it should probably go to asm/system.h or similar and not have a kprobes name - it just extracts the return value from a struct pt_regs after all. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/